Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1337588

Re: [PATCH] arm64: kasan: clear stale stack poison

From Catalin Marinas <catalin.marinas@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] arm64: kasan: clear stale stack poison
Date 2016-02-18 19:00 +0100
Message-ID <r3B1U-Ga-1@gated-at.bofh.it> (permalink)
References <r3AyV-uN-65@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Feb 18, 2016 at 05:27:38PM +0000, Mark Rutland wrote:
> @@ -145,6 +146,7 @@ ENTRY(cpu_resume_mmu)
>  ENDPROC(cpu_resume_mmu)
>  	.popsection
>  cpu_resume_after_mmu:
> +	kasan_unpoison_stack 96

I don't think the 96 here is needed since we populate the stack in
assembly (__cpu_suspend_enter) and unwind it again still in assembly
(cpu_resume_after_mmu), so no KASAN shadow writes/reads.

Otherwise the patch looks fine.

-- 
Catalin

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] arm64: kasan: clear stale stack poison Mark Rutland <mark.rutland@arm.com> - 2016-02-18 18:30 +0100
  Re: [PATCH] arm64: kasan: clear stale stack poison Catalin Marinas <catalin.marinas@arm.com> - 2016-02-18 19:00 +0100
    Re: [PATCH] arm64: kasan: clear stale stack poison Will Deacon <will.deacon@arm.com> - 2016-02-18 19:10 +0100
      Re: [PATCH] arm64: kasan: clear stale stack poison Catalin Marinas <catalin.marinas@arm.com> - 2016-02-18 19:20 +0100
        Re: [PATCH] arm64: kasan: clear stale stack poison Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-02-19 12:00 +0100
        Re: [PATCH] arm64: kasan: clear stale stack poison Mark Rutland <mark.rutland@arm.com> - 2016-02-19 12:40 +0100

csiph-web