Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1337558

[PATCH] dmaengine: pl330: initialize tasklet after spin_unlock_irqrestore

From Anand Moon <linux.amoon@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] dmaengine: pl330: initialize tasklet after spin_unlock_irqrestore
Date 2016-02-18 18:30 +0100
Message-ID <r3AyU-uN-43@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Anand Moon <linux.amoon@gmail.com>

pl330_tasklet tasklet uses the same spinlock pch->lock for safe IRQ locking.
It's safe to initialize pl330_tasklet tasklet after release of the locking.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 drivers/dma/pl330.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 17ee758..df2cab1 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2091,10 +2091,10 @@ static int pl330_alloc_chan_resources(struct dma_chan *chan)
 		return -ENOMEM;
 	}
 
-	tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch);
-
 	spin_unlock_irqrestore(&pch->lock, flags);
 
+	tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch);
+
 	return 1;
 }
 
-- 
1.9.1

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] dmaengine: pl330: initialize tasklet after spin_unlock_irqrestore Anand Moon <linux.amoon@gmail.com> - 2016-02-18 18:30 +0100
  Re: [PATCH] dmaengine: pl330: initialize tasklet after spin_unlock_irqrestore Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-19 07:10 +0100
    Re: [PATCH] dmaengine: pl330: initialize tasklet after spin_unlock_irqrestore Anand Moon <linux.amoon@gmail.com> - 2016-02-19 07:50 +0100
      Re: [PATCH] dmaengine: pl330: initialize tasklet after  spin_unlock_irqrestore Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-19 08:30 +0100
        Re: [PATCH] dmaengine: pl330: initialize tasklet after  spin_unlock_irqrestore Lars-Peter Clausen <lars@metafoo.de> - 2016-02-19 09:20 +0100
          Re: [PATCH] dmaengine: pl330: initialize tasklet after spin_unlock_irqrestore Anand Moon <linux.amoon@gmail.com> - 2016-02-19 09:50 +0100
          Re: [PATCH] dmaengine: pl330: initialize tasklet after spin_unlock_irqrestore Anand Moon <linux.amoon@gmail.com> - 2016-02-21 18:40 +0100
        Re: [PATCH] dmaengine: pl330: initialize tasklet after spin_unlock_irqrestore Anand Moon <linux.amoon@gmail.com> - 2016-02-19 09:20 +0100

csiph-web