Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336275

Re: [PATCH 6/5] oom, oom_reaper: disable oom_reaper for

Show all headers | View raw

On Wed 17-02-16 19:41:53, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > Hi Andrew,
> > although this can be folded into patch 5
> > (mm-oom_reaper-implement-oom-victims-queuing.patch) I think it would be
> > better to have it separate and revert after we sort out the proper
> > oom_kill_allocating_task behavior or handle exclusion at oom_reaper
> > level.
> 
> What a rough workaround. sysctl_oom_kill_allocating_task == 1 does not
> always mean we must skip OOM reaper, for OOM-unkillable callers take
> sysctl_oom_kill_allocating_task == 0 path.

Yes it is indeed rough but also shouldn't add new issues. I consider
oom_kill_allocating_task as a borderline which can be sorted out later.
So while I do not like workarounds like this in general I would rather
go with obvious code first before going for more complex solutions.

> I've just posted a patchset which allows you to merge the OOM reaper
> without correcting problems found in "[PATCH 3/5] oom: clear TIF_MEMDIE
> after oom_reaper managed to unmap the address space" and "[PATCH 5/5]
> mm, oom_reaper: implement OOM victims queuing".

I will try to look at your patches but the series seems unnecessarily
heavy to be a pre-requisite for the oom_reaper.

Thanks!
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 6/5] oom, oom_reaper: disable oom_reaper for Michal Hocko <mhocko@kernel.org> - 2016-02-17 10:50 +0100
  Re: [PATCH 6/5] oom, oom_reaper: disable oom_reaper for Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-02-17 11:50 +0100
    Re: [PATCH 6/5] oom, oom_reaper: disable oom_reaper for Michal Hocko <mhocko@kernel.org> - 2016-02-17 12:40 +0100
  Re: [PATCH 6/5] oom, oom_reaper: disable oom_reaper for Michal Hocko <mhocko@kernel.org> - 2016-02-19 19:40 +0100
    Re: [PATCH 6/5] oom, oom_reaper: disable oom_reaper for oom_kill_allocating_task Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-02-20 03:40 +0100
      Re: [PATCH 6/5] oom, oom_reaper: disable oom_reaper for  oom_kill_allocating_task Michal Hocko <mhocko@kernel.org> - 2016-02-22 10:50 +0100

csiph-web