Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer
Date	2016-02-17 10:50 +0100
Message-ID	<r36Ua-4uj-17@gated-at.bofh.it> (permalink)
References	<r2P6V-Gk-7@gated-at.bofh.it> <r36hs-4dm-3@gated-at.bofh.it> <r36Ku-4qr-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday 17 February 2016 10:35:40 Takashi Iwai wrote:
> From: Takashi Iwai <tiwai@suse.de>
> Subject: [PATCH v2] ALSA: jack: Allow building the jack layer without
>  input device
> 
> Since the recent integration of kctl jack and input jack layers, we
> can basically build the jack layer even without input devices.  That
> is, the jack layer itself can be built with conditional to enable the
> input device support or not, while the users may enable always
> CONFIG_SND_JACK unconditionally.
> 
> For achieving it, this patch changes the following:
> - A new Kconfig, CONFIG_SND_JACK_INPUT_DEV, was introduced to indicate
>   whether the jack layer supports the input device,
> - A few items in snd_jack struct and relevant codes are conditionally
>   built upon CONFIG_SND_JACK_INPUT_DEV,
> - The users of CONFIG_SND_JACK drop the messy dependency on
>   CONFIG_INPUT.
> 
> This change also automagically fixes a potential bug in HD-audio
> driver Arnd reported, where the NULL or uninitialized jack instance is
> dereferenced.
> 
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 

Looks great, that indeed takes care of the issue I reported and
makes the code more useful and more robust overall.

Acked-by: Arnd Bergmann <arnd@arndb.de>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Arnd Bergmann <arnd@arndb.de> - 2016-02-16 15:50 +0100
  Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Takashi Iwai <tiwai@suse.de> - 2016-02-16 16:50 +0100
    Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Arnd Bergmann <arnd@arndb.de> - 2016-02-16 17:20 +0100
      Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Takashi Iwai <tiwai@suse.de> - 2016-02-16 17:20 +0100
        Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack'  pointer Mark Brown <broonie@kernel.org> - 2016-02-16 17:40 +0100
          Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Takashi Iwai <tiwai@suse.de> - 2016-02-16 17:50 +0100
          Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Arnd Bergmann <arnd@arndb.de> - 2016-02-16 18:00 +0100
            Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Arnd Bergmann <arnd@arndb.de> - 2016-02-16 18:20 +0100
            Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Takashi Iwai <tiwai@suse.de> - 2016-02-16 18:20 +0100
              Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Arnd Bergmann <arnd@arndb.de> - 2016-02-16 18:30 +0100
                Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Arnd Bergmann <arnd@arndb.de> - 2016-02-16 23:10 +0100
                Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Takashi Iwai <tiwai@suse.de> - 2016-02-17 10:10 +0100
                Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Takashi Iwai <tiwai@suse.de> - 2016-02-17 10:40 +0100
                Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer Arnd Bergmann <arnd@arndb.de> - 2016-02-17 10:50 +0100

csiph-web