Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1336096
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 |
| Date | 2016-02-17 08:10 +0100 |
| Message-ID | <r34pk-2YG-11@gated-at.bofh.it> (permalink) |
| References | <r34fD-2FN-7@gated-at.bofh.it> <r34fD-2FN-5@gated-at.bofh.it> <r34pk-2YG-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 17.02.2016 16:01, Viresh Kumar wrote:
> On 17-02-16, 15:55, Krzysztof Kozlowski wrote:
>> On Exynos5420 we support 8 cpufreq steps (600-1300 MHz) for LITTLE and
>> 12 steps for big core (700-1800 MHz). Add respective cooling cells.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5420-cpus.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-cpus.dtsi b/arch/arm/boot/dts/exynos5420-cpus.dtsi
>> index 261d25173f61..498ae82e1cb2 100644
>> --- a/arch/arm/boot/dts/exynos5420-cpus.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420-cpus.dtsi
>> @@ -33,6 +33,9 @@
>> clock-frequency = <1800000000>;
>> cci-control-port = <&cci_control1>;
>> operating-points-v2 = <&cluster_a15_opp_table>;
>> + cooling-min-level = <0>;
>> + cooling-max-level = <11>;
>> + #cooling-cells = <2>; /* min followed by max */
>> };
>>
>> cpu1: cpu@1 {
>> @@ -70,6 +73,9 @@
>> clock-frequency = <1000000000>;
>> cci-control-port = <&cci_control0>;
>> operating-points-v2 = <&cluster_a7_opp_table>;
>> + cooling-min-level = <0>;
>> + cooling-max-level = <7>;
>> + #cooling-cells = <2>; /* min followed by max */
>> };
>
> Though it wouldn't matter (for the issue you are getting), but this should be
> added for all the CPUs in case some other CPU is booted first.
Thanks! I'll fix it also for patch 2/3.
Best regards,
Krzysztof
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-17 08:00 +0100 Re: [RFC 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-17 08:10 +0100 Re: [RFC 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-17 08:10 +0100
csiph-web