Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336075

Re: [PATCH v3] phy: marvell: Fix and unify reg-init behavior

Show all headers | View raw

On February 15, 2016 2:46:45 PM PST, Clemens Gruber <clemens.gruber@pqgruber.com> wrote:
>For the Marvell 88E1510, marvell_of_reg_init was called too late, in
>the
>config_aneg function.
>Since commit 113c74d83eef ("net: phy: turn carrier off on phy attach"),
>this lead to the link not coming up at boot anymore, due to the phy
>state machine being stuck at waiting for interrupts (off by default on
>the 88E1510).
>For seven other Marvell PHYs, marvell_of_reg_init was not called at
>all.
>
>Add a generic marvell_config_init function, which in turn calls
>marvell_of_reg_init.
>PHYs, which already have a specific config_init function with a call to
>marvell_of_reg_init, are left untouched. The generic
>marvell_config_init
>function is called for all the others, to get consistent behavior
>across
>all Marvell PHYs.
>
>Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!

-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] phy: marvell: Fix and unify reg-init behavior Clemens Gruber <clemens.gruber@pqgruber.com> - 2016-02-15 23:50 +0100
  Re: [PATCH v3] phy: marvell: Fix and unify reg-init behavior Andrew Lunn <andrew@lunn.ch> - 2016-02-16 16:30 +0100
    Re: [PATCH v3] phy: marvell: Fix and unify reg-init behavior David Miller <davem@davemloft.net> - 2016-02-17 22:30 +0100
  Re: [PATCH v3] phy: marvell: Fix and unify reg-init behavior Florian Fainelli <f.fainelli@gmail.com> - 2016-02-17 07:40 +0100

csiph-web