[PATCH] rtnl: RTM_GETNETCONF: fix wrong return value

From	Anton Protopopov <a.s.protopopov@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] rtnl: RTM_GETNETCONF: fix wrong return value
Date	2016-02-17 03:50 +0100
Message-ID	<r30lI-8gb-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

An error response from a RTM_GETNETCONF request can return the positive
error value EINVAL in the struct nlmsgerr that can mislead userspace.

Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
---
 net/ipv4/devinet.c  | 2 +-
 net/ipv6/addrconf.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index cebd9d3..f6303b1 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1847,7 +1847,7 @@ static int inet_netconf_get_devconf(struct sk_buff *in_skb,
 	if (err < 0)
 		goto errout;
 
-	err = EINVAL;
+	err = -EINVAL;
 	if (!tb[NETCONFA_IFINDEX])
 		goto errout;
 
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 9efd9ff..bdd7eac 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -583,7 +583,7 @@ static int inet6_netconf_get_devconf(struct sk_buff *in_skb,
 	if (err < 0)
 		goto errout;
 
-	err = EINVAL;
+	err = -EINVAL;
 	if (!tb[NETCONFA_IFINDEX])
 		goto errout;
 
-- 
2.6.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] rtnl: RTM_GETNETCONF: fix wrong return value Anton Protopopov <a.s.protopopov@gmail.com> - 2016-02-17 03:50 +0100
  Re: [PATCH] rtnl: RTM_GETNETCONF: fix wrong return value Cong Wang <xiyou.wangcong@gmail.com> - 2016-02-18 00:00 +0100
  Re: [PATCH] rtnl: RTM_GETNETCONF: fix wrong return value David Miller <davem@davemloft.net> - 2016-02-19 21:40 +0100

csiph-web