Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334761

Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

Show all headers | View raw

On Mon, Feb 15, 2016 at 12:50:41PM -0600, Michael Welling wrote:
> On Mon, Feb 15, 2016 at 10:15:08AM -0800, Greg Kroah-Hartman wrote:
> > On Sun, Feb 14, 2016 at 09:08:50PM -0600, Michael Welling wrote:
> > > On Sun, Feb 14, 2016 at 03:17:36PM -0800, Greg Kroah-Hartman wrote:
> > > > On Sun, Feb 14, 2016 at 04:50:47PM -0600, Michael Welling wrote:
> > > > > On Sun, Feb 14, 2016 at 02:20:48PM -0800, Greg Kroah-Hartman wrote:
> > > > > > 4.3-stable review patch.  If anyone has any objections, please let me know.
> > > > > >
> > > > > 
> > > > > If not planned it should be considered that we include the latest two
> > > > > commits to spi-omap2-mcpsi into stable as well.
> > > > > 
> > > > > spi: omap2-mcspi: Prevent duplicate gpio_request
> > > > > spi: omap2-mcspi: Add calls for pinctrl state select 
> > > > > 
> > > > > Let me know if I need to do anything to make this happen.
> > > > 
> > > > What are the git commit ids of them?
> > > 
> > > commit 2f538c017e1a8620d19553931199c6d6a6d31bb2
> > > Author: Michael Welling <mwelling@ieee.org>
> > > Date:   Mon Nov 30 09:02:39 2015 -0600
> > > 
> > >     spi: omap2-mcspi: Prevent duplicate gpio_request
> > >     
> > >     Occasionally the setup function will be called multiple times. Only request
> > >     the gpio the first time otherwise -EBUSY will occur on subsequent calls to
> > >     setup.
> > >     
> > >     Reported-by: Joseph Bell <joe@iachieved.it>
> > >     
> > >     Signed-off-by: Michael Welling <mwelling@ieee.org>
> > >     Signed-off-by: Mark Brown <broonie@kernel.org>
> > 
> > That seems reasonable but:
> > 
> > > commit beca365565d8f8912dce67567f54ad4c71734843
> > > Author: Pascal Huerst <pascal.huerst@gmail.com>
> > > Date:   Thu Nov 19 16:18:28 2015 +0100
> > > 
> > >     spi: omap2-mcspi: Add calls for pinctrl state select
> > >     
> > >     This adds calls to pinctrl subsystem in order to switch pin states
> > >     on suspend/resume if you provide a "sleep" state in DT.
> > >     
> > >     If no "sleep" state is provided in DT, these calls turn
> > >     to NOPs.
> > >     
> > >     Signed-off-by: Pascal Huerst <pascal.huerst@gmail.com>
> > >     Signed-off-by: Mark Brown <broonie@kernel.org>
> > 
> > That looks like a new feature being added.
> > 
> > > > What stable tree(s) do you want
> > > > them applied to?
> > > 
> > > v4.3, v4.4
> > 
> > 4.3 is now end-of-life with this release, can you live with these just
> > in 4.4-stable instead?
> 
> v4.4 stable is good enough.
> 
> Let me know what needs to be done if anything.

That last patch does not seem like it follows the rules documented at
Documentation/stable_kernel_rules.txt, so I can't take it.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-14 23:40 +0100
  Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Michael Welling <mwelling@ieee.org> - 2016-02-15 00:00 +0100
    Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-15 01:30 +0100
      Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Michael Welling <mwelling@ieee.org> - 2016-02-15 04:10 +0100
        Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-15 19:20 +0100
          Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Michael Welling <mwelling@ieee.org> - 2016-02-15 20:00 +0100
            Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-15 20:40 +0100
              Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Michael Welling <mwelling@ieee.org> - 2016-02-15 21:10 +0100
    Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Mark Brown <broonie@kernel.org> - 2016-02-15 12:10 +0100
      Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Michael Welling <mwelling@ieee.org> - 2016-02-15 16:30 +0100
        Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels  CHCONF_FORCE in prepare_message Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-15 19:20 +0100

csiph-web