Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334787

Re: [PATCH 1/4] gpio: remove broken irq_to_gpio() interface

Show all headers | View raw

On Monday 15 February 2016 17:01:09 Lars-Peter Clausen wrote:
> On 02/15/2016 04:46 PM, Arnd Bergmann wrote:
> > +static inline __deprecated int irq_to_gpio(unsigned int irq)
> > +{
> > +     /* this has clearly not worked for a long time */
> > +     return -EINVAL;
> > +}
> > +
> >  #define IRQ_TO_BIT(irq) BIT(irq_to_gpio(irq) & 0x1f)
> 
> The issue seems to be a fallout from commit 832f5dacfa0b ("MIPS: Remove all
> the uses of custom gpio.h").
> 
> The irq_to_gpio() should be replaced with "(irq - JZ4740_IRQ_GPIO(0))".
> 
> 

Ah, that explain it, so it has not been broken for that long.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] clean up irq_to_gpio and asm/gpio.h Arnd Bergmann <arnd@arndb.de> - 2016-02-15 16:50 +0100
  [PATCH 1/4] gpio: remove broken irq_to_gpio() interface Arnd Bergmann <arnd@arndb.de> - 2016-02-15 16:50 +0100
    Re: [PATCH 1/4] gpio: remove broken irq_to_gpio() interface Lars-Peter Clausen <lars@metafoo.de> - 2016-02-15 17:10 +0100
      Re: [PATCH 1/4] gpio: remove broken irq_to_gpio() interface Arnd Bergmann <arnd@arndb.de> - 2016-02-15 21:20 +0100
    Re: [PATCH 1/4] gpio: remove broken irq_to_gpio() interface Arnd Bergmann <arnd@arndb.de> - 2016-02-16 16:50 +0100
      Re: [PATCH 1/4] gpio: remove broken irq_to_gpio() interface Linus Walleij <linus.walleij@linaro.org> - 2016-02-16 17:00 +0100
    Re: [PATCH 1/4] gpio: remove broken irq_to_gpio() interface Linus Walleij <linus.walleij@linaro.org> - 2016-02-16 16:50 +0100

csiph-web