Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334724

Re: [PATCH 1/2] firmware: arm_scpi: add support for 64-bit sensor values

Show all headers | View raw

Sudeep Holla <sudeep.holla@arm.com> writes:

> SCPI specification version 1.1 extended the sensor from 32-bit to 64-bit
> values in order to accommodate new sensor class with 64-bit requirements
>
> Since the SCPI driver sets the higher 32-bit for older protocol version
> to zeros, there's no need to explicitly check the SCPI protocol version
> and the backward compatibility is maintainted.
>
> Cc: Punit Agrawal <punit.agrawal@arm.com>

Thanks for the update to the driver.

       Reviewed-by: Punit Agrawal <punit.agrawal@arm.com>

> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/firmware/arm_scpi.c   | 8 +++++---
>  drivers/hwmon/scpi-hwmon.c    | 6 +++---
>  include/linux/scpi_protocol.h | 2 +-
>  3 files changed, 9 insertions(+), 7 deletions(-)
>
> Hi Guenter,
>
> Since I have couple of other fixes for SCPI driver, if you can provide
> your ACKs to this couple of patches after your review, I can take all of
> them together via ARM-SoC if that's fine with you.
>
> Regards,
> Sudeep
>

[...]

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] firmware: arm_scpi: add support for 64-bit sensor values Sudeep Holla <sudeep.holla@arm.com> - 2016-02-09 15:40 +0100
  [PATCH 2/2] hwmon: (scpi) add energy meter support Sudeep Holla <sudeep.holla@arm.com> - 2016-02-09 15:40 +0100
    Re: [PATCH 2/2] hwmon: (scpi) add energy meter support Punit Agrawal <punit.agrawal@arm.com> - 2016-02-15 19:50 +0100
    Re: [PATCH 2/2] hwmon: (scpi) add energy meter support Guenter Roeck <linux@roeck-us.net> - 2016-02-16 02:50 +0100
  Re: [PATCH 1/2] firmware: arm_scpi: add support for 64-bit sensor values Punit Agrawal <punit.agrawal@arm.com> - 2016-02-15 19:50 +0100
  Re: [PATCH 1/2] firmware: arm_scpi: add support for 64-bit sensor  values Guenter Roeck <linux@roeck-us.net> - 2016-02-16 02:50 +0100

csiph-web