Re: [PATCH] phy: marvell: Fix and unify reg-init behavior

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] phy: marvell: Fix and unify reg-init behavior
Date	2016-02-15 19:30 +0100
Message-ID	<r2w4j-4N8-33@gated-at.bofh.it> (permalink)
References	<r2vBj-4if-49@gated-at.bofh.it> <r2vUC-4Jg-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 15/02/2016 10:19, Florian Fainelli wrote:
> On 15/02/2016 09:52, Clemens Gruber wrote:
>> For the Marvell 88E1510, marvell_of_reg_init was called too late (in
>> m88e1510_config_aneg), which lead to the phy state machine being stuck
>> at waiting for interrupts, which are off by default on the 88E1510.
>> This further lead to the ethernet link not coming up at boot.
>> For some Marvell PHYs, marvell_of_reg_init was not called at all.
> 
> You could mention that this became apparent with

...
113c74d83eef ("net: phy: turn carrier off on phy attach")
--
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] phy: marvell: Fix and unify reg-init behavior Clemens Gruber <clemens.gruber@pqgruber.com> - 2016-02-15 19:00 +0100
  Re: [PATCH] phy: marvell: Fix and unify reg-init behavior Florian Fainelli <f.fainelli@gmail.com> - 2016-02-15 19:20 +0100
    Re: [PATCH] phy: marvell: Fix and unify reg-init behavior Florian Fainelli <f.fainelli@gmail.com> - 2016-02-15 19:30 +0100

csiph-web