Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334599

Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select

Show all headers | View raw

CC'ing a few others.

On Fri, 12 Feb 2016, Arnd Bergmann wrote:
> The Xen framebuffer driver selects the xen keyboard driver, so the latter
> will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT
> is a loadable module, this configuration cannot work. On mainline kernels,
> the symbol will be enabled but not used, while in combination with
> a patch I have to detect such useless configurations, we get the
> expected link failure:
> 
> drivers/input/built-in.o: In function `xenkbd_remove':
> xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device'
> xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device'
> 
> This changes the dependencies of XEN_FBDEV_FRONTEND so it cannot be
> built-in if CONFIG_INPUT=m && CONFIG_INPUT_MISC=y, as that would result
> in the broken select.
> 
> As usual, we would be much better off without the 'select', but removing
> it now would likely break existing user configurations that depend on
> it, so this adds another hack on top to get it working.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND")
> ---
>  drivers/video/fbdev/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 8ea45a5cd806..fd3d6fd290a9 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -2241,6 +2241,7 @@ config FB_VIRTUAL
>  config XEN_FBDEV_FRONTEND
>  	tristate "Xen virtual frame buffer support"
>  	depends on FB && XEN
> +	depends on INPUT || !INPUT_MISC
>  	select FB_SYS_FILLRECT
>  	select FB_SYS_COPYAREA
>  	select FB_SYS_IMAGEBLIT

This looks very hackish. Couldn't we just do the following?

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 8ea45a5..3c15f6d 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND
 	select FB_SYS_IMAGEBLIT
 	select FB_SYS_FOPS
 	select FB_DEFERRED_IO
-	select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
+	select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC)
 	select XEN_XENBUS_FRONTEND
 	default y
 	help

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Arnd Bergmann <arnd@arndb.de> - 2016-02-12 13:10 +0100
  Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Andrew Jones <drjones@redhat.com> - 2016-02-12 15:00 +0100
  Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-02-15 18:00 +0100
    Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-02-15 18:10 +0100
      [PATCH v2] xen kconfig: don't "select INPUT_XEN_KBDDEV_FRONTEND" Arnd Bergmann <arnd@arndb.de> - 2016-02-16 16:10 +0100
        Re: [PATCH v2] xen kconfig: don't "select  INPUT_XEN_KBDDEV_FRONTEND" Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-02-16 18:00 +0100
    Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select David Vrabel <david.vrabel@citrix.com> - 2016-02-15 18:10 +0100
    Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Arnd Bergmann <arnd@arndb.de> - 2016-02-16 12:40 +0100
      Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-02-16 13:20 +0100
        Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Arnd Bergmann <arnd@arndb.de> - 2016-02-16 16:10 +0100

csiph-web