Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1334532
| From | Jes Sorensen <Jes.Sorensen@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes |
| Date | 2016-02-15 16:40 +0100 |
| Message-ID | <r2tpL-2SR-1@gated-at.bofh.it> (permalink) |
| References | <qZomC-iR-3@gated-at.bofh.it> <qZomC-iR-3@gated-at.bofh.it> <qZomC-iR-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Geliang Tang <geliangtang@163.com> writes:
> There are some useless codes in rtw_free_recvframe23a_queue() and
> recvframe_defrag(), so remove them.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> Changes in v3:
> - split it into three patches.
> Changes in v2:
> - drop the coding style fixing in v1.
> ---
> drivers/staging/rtl8723au/core/rtw_recv.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
I assume this requires patch 1/3 applied first?
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c
> index 18b7d03..b36bc6b 100644
> --- a/drivers/staging/rtl8723au/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723au/core/rtw_recv.c
> @@ -201,7 +201,6 @@ static void rtw_free_recvframe23a_queue(struct rtw_queue *pframequeue)
> spin_lock(&pframequeue->lock);
>
> phead = get_list_head(pframequeue);
> - plist = phead->next;
>
> list_for_each_entry_safe(hdr, ptmp, phead, list) {
> rtw_free_recvframe23a(hdr);
> @@ -1567,7 +1566,7 @@ struct recv_frame *recvframe_defrag(struct rtw_adapter *adapter,
> struct rtw_queue *defrag_q)
> {
> struct list_head *plist, *phead;
> - u8 *data, wlanhdr_offset;
> + u8 wlanhdr_offset;
> u8 curfragnum;
> struct recv_frame *pnfhdr, *ptmp;
> struct recv_frame *prframe, *pnextrframe;
> @@ -1596,10 +1595,6 @@ struct recv_frame *recvframe_defrag(struct rtw_adapter *adapter,
>
> curfragnum++;
>
> - phead = get_list_head(defrag_q);
> -
> - data = prframe->pkt->data;
> -
> list_for_each_entry_safe(pnfhdr, ptmp, phead, list) {
> pnextrframe = (struct recv_frame *)pnfhdr;
> /* check the fragment sequence (2nd ~n fragment frame) */
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-02-15 16:40 +0100
csiph-web