Re: [PATCH] rtc: s3c: Document in binding that only s3c6410 needs a src clk

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtc: s3c: Document in binding that only s3c6410 needs a src clk
Date	2016-02-15 15:00 +0100
Message-ID	<r2rR2-1Jl-33@gated-at.bofh.it> (permalink)
References	<r2rej-1tR-7@gated-at.bofh.it> <r2rHj-1Fu-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Alexandre,

On 02/15/2016 10:45 AM, Alexandre Belloni wrote:
> On 15/02/2016 at 10:16:42 -0300, Javier Martinez Canillas wrote :
>> Commit 43f3408261a2 ("rtc: s3c: Document required clocks in the DT
>
> I'm pretty sure you shouldn't refer to a commit that is in linux-next.
>

The commit comes from Rob's dt/linus branch that uses Linux 4.5-rc3 as
a base. I'm not a git expert but I thought that if the branch is not
rebased and used for the pull request then the resulting commit in
mainline would end with the same sha-1.

But I can remove the mention to the commit and "Fixes:" tag since the
commit is not yet in mainline, that should be more safe indeed.

>> binding") added to the S3C binding doc the required clocks needed
>> by the Real Time Clock but the S3C driver supports different HW IP
>> and only the s3c6410 needs a source clock.
>>
>> Fix the DT binding explaning that the second clock is only needed
>            explaining ^

Ok, I'll fix that typo.

>> by this IP block and not for the others.
>>
>> Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Fixes: 43f3408261a2 ("rtc: s3c: Document required clocks in the DT binding")
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>
> Anyway, I'm fine with it, feel free to add my ack.
>

Thanks, I'll add it in v2.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: s3c: Document in binding that only s3c6410 needs a src clk Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-15 14:20 +0100
  Re: [PATCH] rtc: s3c: Document in binding that only s3c6410 needs a  src clk Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-02-15 14:50 +0100
    Re: [PATCH] rtc: s3c: Document in binding that only s3c6410 needs a  src clk Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-15 15:00 +0100

csiph-web