Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334411

[REGRESSION, bisected] 4.5rc4 sound fsl-soc

Show key headers only | View raw

Hi,

The following commit :

5c408fee254633a5be69505bc86c6b034f871ab4 is the first bad commit
commit 5c408fee254633a5be69505bc86c6b034f871ab4
Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Date:   Mon Jan 18 20:07:44 2016 +0100

    ASoC: fsl_ssi: remove explicit register defaults
    	
    There is no guarantee that on fsl_ssi module load
    SSI registers will have their power-on-reset values.
    
    In fact, if the driver is reloaded the values in
    registers will be whatever they were set to previously.
    
    However, the cache needs to be fully populated at probe
    time to avoid non-atomic allocations during register
    access.
    
    Special case here is imx21-class SSI, since
    according to datasheet it don't have SACC{ST,EN,DIS}
    regs.
    
    This fixes hard lockup on fsl_ssi module reload,
    at least in AC'97 mode.
    
    Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast")
    Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
    Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>


causes regmap init failure when loading the sgtl5000 codec on imx6q, and
leads to no audio.

With the mentioned patch reverted sound works ok.

--Mika

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[REGRESSION, bisected] 4.5rc4 sound fsl-soc Mika Penttilä <mika.penttila@nextfour.com> - 2016-02-15 12:30 +0100
  Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc Fabio Estevam <fabio.estevam@nxp.com> - 2016-02-15 13:10 +0100
    Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc Fabio Estevam <festevam@gmail.com> - 2016-02-15 17:00 +0100
    Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc Mika Penttilä <mika.penttila@nextfour.com> - 2016-02-20 22:00 +0100
      Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc Mark Brown <broonie@kernel.org> - 2016-02-20 22:30 +0100

csiph-web