Re: [PATCH v4 2/8] [media] VPU: mediatek: support Mediatek VPU

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	tiffany lin <tiffany.lin@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/8] [media] VPU: mediatek: support Mediatek VPU
Date	Mon, 15 Feb 2016 12:30:01 +0100
Message-ID	<r2pvP-e6-1@gated-at.bofh.it> (permalink)
References	<qYqqt-81W-7@gated-at.bofh.it> <qYqqt-81W-9@gated-at.bofh.it> <qYqqt-81W-11@gated-at.bofh.it> <r2oq6-7YN-17@gated-at.bofh.it>
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.2.3-0ubuntu6
Content-Transfer-Encoding	7bit
MIME-Version	1.0
X-Mtk	N
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	70
Organization	linux.* mail to news gateway
X-Original-Cc	Hans Verkuil <hans.verkuil@cisco.com>, <daniel.thompson@linaro.org>, "Rob Herring" <robh+dt@kernel.org>, Mauro Carvalho Chehab <mchehab@osg.samsung.com>, Matthias Brugger <matthias.bgg@gmail.com>, Daniel Kurtz <djkurtz@chromium.org>, Pawel Osciak <posciak@chromium.org>, Eddie Huang <eddie.huang@mediatek.com>, Yingjoe Chen <yingjoe.chen@mediatek.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-media@vger.kernel.org>, <linux-mediatek@lists.infradead.org>, <PoChun.Lin@mediatek.com>, Andrew-CT Chen <andrew-ct.chen@mediatek.com>
X-Original-Date	Mon, 15 Feb 2016 19:27:36 +0800
X-Original-Message-ID	<1455535656.27088.6.camel@mtksdaap41>
X-Original-References	<1454585703-42428-1-git-send-email-tiffany.lin@mediatek.com> <1454585703-42428-2-git-send-email-tiffany.lin@mediatek.com> <1454585703-42428-3-git-send-email-tiffany.lin@mediatek.com> <56C1A4C6.7040601@xs4all.nl>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1334405

Show key headers only | View raw

On Mon, 2016-02-15 at 11:13 +0100, Hans Verkuil wrote:
> On 02/04/2016 12:34 PM, Tiffany Lin wrote:
> > The VPU driver for hw video codec embedded in Mediatek's MT8173 SOCs.
> > It is able to handle video decoding/encoding of in a range of formats.
> > The driver provides with VPU firmware download, memory management and
> > the communication interface between CPU and VPU.
> > For VPU initialization, it will create virtual memory for CPU access and
> > IOMMU address for vcodec hw device access. When a decode/encode instance
> > opens a device node, vpu driver will download vpu firmware to the device.
> > A decode/encode instant will decode/encode a frame using VPU
> > interface to interrupt vpu to handle decoding/encoding jobs.
> > 
> > Signed-off-by: Andrew-CT Chen <andrew-ct.chen@mediatek.com>
> > Signed-off-by: Tiffany Lin <tiffany.lin@mediatek.com>
> > ---
> >  drivers/media/platform/Kconfig           |    9 +
> >  drivers/media/platform/Makefile          |    2 +
> >  drivers/media/platform/mtk-vpu/Makefile  |    1 +
> >  drivers/media/platform/mtk-vpu/mtk_vpu.c |  994 ++++++++++++++++++++++++++++++
> >  drivers/media/platform/mtk-vpu/mtk_vpu.h |  167 +++++
> >  5 files changed, 1173 insertions(+)
> >  create mode 100644 drivers/media/platform/mtk-vpu/Makefile
> >  create mode 100644 drivers/media/platform/mtk-vpu/mtk_vpu.c
> >  create mode 100644 drivers/media/platform/mtk-vpu/mtk_vpu.h
> > 
> > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> > index ccbc974..ba812d6 100644
> > --- a/drivers/media/platform/Kconfig
> > +++ b/drivers/media/platform/Kconfig
> > @@ -148,6 +148,15 @@ config VIDEO_CODA
> >  	   Coda is a range of video codec IPs that supports
> >  	   H.264, MPEG-4, and other video formats.
> >  
> > +config VIDEO_MEDIATEK_VPU
> > +	tristate "Mediatek Video Processor Unit"
> > +	depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MEDIATEK
> > +	---help---
> > +	    This driver provides downloading VPU firmware and
> > +	    communicating with VPU. This driver for hw video
> > +	    codec embedded in new Mediatek's SOCs. It is able
> > +	    to handle video decoding/encoding in a range of formats.
> 
> Can you be more specific in this text and mention for which Mediatek SoCs
> this driver is for? Just like you did in the commit log.
> 
Got it. We will add more specific description in Kconfig in next
version.

> Also add something like this:
> 
>           To compile this driver as a module, choose M here: the module
>           will be called mtk-vpu.
> 
> I always find it useful if the Kconfig text mentions the module name.
> 
Got it. We will fix this. Thanks for sharing experience.


best regards,
Tiffany

> Regards,
> 
> 	Hans
> 
> > +
> >  config VIDEO_MEM2MEM_DEINTERLACE
> >  	tristate "Deinterlace support"
> >  	depends on VIDEO_DEV && VIDEO_V4L2 && DMA_ENGINE
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 2/8] [media] VPU: mediatek: support Mediatek VPU Hans Verkuil <hverkuil@xs4all.nl> - 2016-02-15 11:20 +0100
  Re: [PATCH v4 2/8] [media] VPU: mediatek: support Mediatek VPU tiffany lin <tiffany.lin@mediatek.com> - 2016-02-15 12:30 +0100

csiph-web