Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1334398
| From | Joao Pinto <Joao.Pinto@synopsys.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7 3/3] add support for DWC UFS Host Controller |
| Date | 2016-02-15 12:20 +0100 |
| Message-ID | <r2pmb-aS-33@gated-at.bofh.it> (permalink) |
| References | <r0Yo2-8d-19@gated-at.bofh.it> <r0Yo2-8d-37@gated-at.bofh.it> <r1IqS-5k6-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Akinobu,
On 2/13/2016 1:27 PM, Akinobu Mita wrote:
> Hi Joao,
>
> 2016-02-11 21:13 GMT+09:00 Joao Pinto <Joao.Pinto@synopsys.com>:
>> +static int ufshcd_dwc_connection_setup(struct ufs_hba *hba)
>> +{
>> + int ret = 0;
>> +
>> + /* Local side Configuration */
>> + ret = ufshcd_dme_set(hba, UIC_ARG_MIB(T_CONNECTIONSTATE), 0);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_set(hba, UIC_ARG_MIB(N_DEVICEID), 0);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_set(hba, UIC_ARG_MIB(N_DEVICEID_VALID), 0);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_set(hba, UIC_ARG_MIB(T_PEERDEVICEID), 1);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_set(hba, UIC_ARG_MIB(T_PEERCPORTID), 0);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_set(hba, UIC_ARG_MIB(T_TRAFFICCLASS), 0);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_set(hba, UIC_ARG_MIB(T_CPORTFLAGS), 0x6);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_set(hba, UIC_ARG_MIB(T_CPORTMODE), 1);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_set(hba, UIC_ARG_MIB(T_CONNECTIONSTATE), 1);
>> + if (ret)
>> + goto out;
>> +
>> +
>> + /* Peer side Configuration */
>> + ret = ufshcd_dme_peer_set(hba, UIC_ARG_MIB(T_CONNECTIONSTATE), 0);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_peer_set(hba, UIC_ARG_MIB(N_DEVICEID), 1);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_peer_set(hba, UIC_ARG_MIB(N_DEVICEID_VALID), 1);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_peer_set(hba, UIC_ARG_MIB(T_PEERDEVICEID), 1);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_peer_set(hba, UIC_ARG_MIB(T_PEERCPORTID), 0);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_peer_set(hba, UIC_ARG_MIB(T_TRAFFICCLASS), 0);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_peer_set(hba, UIC_ARG_MIB(T_CPORTFLAGS), 0x6);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_peer_set(hba, UIC_ARG_MIB(T_CPORTMODE), 1);
>> + if (ret)
>> + goto out;
>> +
>> + ret = ufshcd_dme_peer_set(hba, UIC_ARG_MIB(T_CONNECTIONSTATE), 1);
>> + if (ret)
>> + goto out;
>> +
>> +out:
>> + return ret;
>> +}
>
> This looks a bit redundant. The most part of the functions in this file is
> doing ufshcd_dme_set() or ufshcd_dme_peer_set(), so should we
> introduce ufshcd_dme_set_attrs() like below? It will also increase
> readability.
We can do that, it would make the function body lighter and more easy to read I
agree with you!
>
> struct ufshcd_dme_attr_val {
> u32 attr_sel;
> u32 mib_val;
> u8 peer;
> };
>
> int ufshcd_dme_set_attrs(struct ufs_hba *hba,
> const struct ufshcd_dme_attr_val *v, int n)
> {
> for (i = 0; i < n; i++) {
> int ret = ufshcd_dme_set_attr(hba, v[i].attr_sel, ...);
>
> if (ret)
> return ret;
> }
> return 0;
> }
>
> static int ufshcd_dwc_connection_setup(struct ufs_hba *hba)
> {
> const struct ufshcd_dme_attr setup_attrs[] = {
> { UIC_ARG_MIB(T_CONNECTIONSTATE), 0, DME_LOCAL },
> { UIC_ARG_MIB(T_DEVICEID), 0, DME_LOCAL },
> ...
> };
>
> return ufshcd_dme_set_attrs(hba, setup_attrs, ARRAY_SIZE(setup_attrs));
> }
>
>> +static int ufshcd_dwc_setup_tc(struct ufs_hba *hba)
>> +{
>> + int ret = 0;
>> +
>> +#ifdef CONFIG_SCSI_UFS_DWC_40BIT_RMMI
>> + dev_info(hba->dev, "Configuring Test Chip 40-bit RMMI");
>> + ret = ufshcd_dwc_setup_40bit_rmmi(hba);
>> + if (ret) {
>> + dev_err(hba->dev, "Configuration failed");
>
> Please add \n in the end of message.
> (and there are same issues in this file)
>
>> +
>> +/* Clock Divider Values: Hex equivalent of frequency in MHz */
>> +enum clk_div_values {
>> + UFSHCD_CLK_DIV_62_5 = 0x3e,
>> + UFSHCD_CLK_DIV_125 = 0x7d,
>> + UFSHCD_CLK_DIV_200 = 0xc8,
>> +};
>
> This is used as register value for DWC_UFS_REG_HCLKDIV. So should they
> have similar prefix (DWC_UFS_REG_HCLKDIV_*)?
I agree with you, they should have since they are DWC specific.
>
>> diff --git a/drivers/scsi/ufs/unipro.h b/drivers/scsi/ufs/unipro.h
>
> ...
>
>> +/*Other attributes*/
>> +#define VS_MPHYCFGUPDT 0xD085
>> +#define VS_DEBUGOMC 0xD09E
>> +#define VS_POWERSTATE 0xD083
>
> Are these vendor specific attributes? If so, please move them to
> ufshci-dwc.h.
These are not DWC specific, that's why I added them to the common unipro.h
>
Thanks.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v7 0/3] add support for DWC UFS Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-11 13:20 +0100
[PATCH v7 3/3] add support for DWC UFS Host Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-11 13:20 +0100
Re: [PATCH v7 3/3] add support for DWC UFS Host Controller Rob Herring <robh@kernel.org> - 2016-02-12 17:40 +0100
Re: [PATCH v7 3/3] add support for DWC UFS Host Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-12 19:00 +0100
Re: [PATCH v7 3/3] add support for DWC UFS Host Controller Rob Herring <robh@kernel.org> - 2016-02-12 20:40 +0100
Re: [PATCH v7 3/3] add support for DWC UFS Host Controller Akinobu Mita <akinobu.mita@gmail.com> - 2016-02-13 14:30 +0100
Re: [PATCH v7 3/3] add support for DWC UFS Host Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-15 12:20 +0100
[PATCH v7 2/3] added UFS 2.0 capabilities Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-11 13:20 +0100
[PATCH v7 1/3] fixed typo in ufshcd-pltfrm Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-11 13:20 +0100
csiph-web