Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334376

Re: [PATCH 5/5] efi: Make efivarfs entries immutable by default

Show all headers | View raw

On Fri, 12 Feb, at 11:27:12AM, Matt Fleming wrote:
> From: Peter Jones <pjones@redhat.com>
> 
> "rm -rf" is bricking some peoples' laptops because of variables being
> used to store non-reinitializable firmware driver data that's required
> to POST the hardware.
> 
> These are 100% bugs, and they need to be fixed, but in the mean time it
> shouldn't be easy to *accidentally* brick machines.
> 
> We have to have delete working, and picking which variables do and don't
> work for deletion is quite intractable, so instead make everything
> immutable by default (except for a whitelist), and make tools that
> aren't quite so broad-spectrum unset the immutable flag.
> 
> Signed-off-by: Peter Jones <pjones@redhat.com>
> Tested-by: "Lee, Chun-Yi" <jlee@suse.com>
> Acked-by: Matthew Garrett <mjg59@coreos.com>
> Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
> ---
>  Documentation/filesystems/efivarfs.txt         |  7 +++
>  drivers/firmware/efi/vars.c                    | 87 +++++++++++++++++++-------
>  fs/efivarfs/file.c                             | 70 +++++++++++++++++++++
>  fs/efivarfs/inode.c                            | 30 +++++----
>  fs/efivarfs/internal.h                         |  3 +-
>  fs/efivarfs/super.c                            |  9 ++-
>  include/linux/efi.h                            |  2 +
>  tools/testing/selftests/efivarfs/efivarfs.sh   | 19 +++++-
>  tools/testing/selftests/efivarfs/open-unlink.c | 72 ++++++++++++++++++++-
>  9 files changed, 258 insertions(+), 41 deletions(-)

Folks, please hold off on merging this patch as Laszlo has raised a
good point about including the efi-pstore variables in the whitelist.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 0/5] EFI urgent fixes Matt Fleming <matt@codeblueprint.co.uk> - 2016-02-12 12:30 +0100
  [PATCH 5/5] efi: Make efivarfs entries immutable by default Matt Fleming <matt@codeblueprint.co.uk> - 2016-02-12 12:30 +0100
    Re: [PATCH 5/5] efi: Make efivarfs entries immutable by default Matt Fleming <matt@codeblueprint.co.uk> - 2016-02-15 12:00 +0100
  [PATCH 4/5] efi: Make our variable validation list include the guid Matt Fleming <matt@codeblueprint.co.uk> - 2016-02-12 12:30 +0100
  [PATCH 3/5] efi: Do variable name validation tests in utf8 Matt Fleming <matt@codeblueprint.co.uk> - 2016-02-12 12:30 +0100
  [PATCH 1/5] lib/ucs2_string: Add ucs2 -> utf8 helper functions Matt Fleming <matt@codeblueprint.co.uk> - 2016-02-12 12:30 +0100
  Re: [GIT PULL 0/5] EFI urgent fixes Ingo Molnar <mingo@kernel.org> - 2016-02-16 13:20 +0100
    Re: [GIT PULL 0/5] EFI urgent fixes Matt Fleming <matt@codeblueprint.co.uk> - 2016-02-16 14:00 +0100
      Re: [GIT PULL 0/5] EFI urgent fixes Ingo Molnar <mingo@kernel.org> - 2016-02-17 09:00 +0100
        Re: [GIT PULL 0/5] EFI urgent fixes Matt Fleming <matt@codeblueprint.co.uk> - 2016-02-17 11:20 +0100

csiph-web