Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334368

Re: [PATCH] drivers: stm: correct the index in master array release

Show all headers | View raw

Chunyan Zhang <zhang.chunyan@linaro.org> writes:

> On Tue, Feb 9, 2016 at 6:12 PM, Alexander Shishkin
> <alexander.shishkin@linux.intel.com> wrote:
>> Chunyan Zhang <zhang.chunyan@linaro.org> writes:
>>
>>> It would be broken if stm_data->sw_start isn't zero, because that
>>> stp_master_free() get the 'master' with __stm_master()/stm_master(),
>>> in which the masterID is the second input parameter minus
>>> stm_data->sw_start. So freeing STM masters has to start from
>>> stm_data->sw_start.
>>
>> No, it won't. stm_master_free() handles nonexistent masters correctly.
>> It does make sense to shrink the loop in stm_unregister_device() to
>> avoid going through the [0..sw_start) range, since stm_master() returns
>> NULL for those, but not for the reasons given in this patch description.
>
> Let's assume sw_start = 64, sw_end = 79, sw_nmasters should be 16, if
> the loop goes through [0..16), the existed masters will not be freed.

Ah yes, you're right, of course.

I'll add this fix to the queue with a proper description.

Thanks,
--
Alex

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] drivers: stm: correct the index in master array release Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-09 11:20 +0100
  Re: [PATCH] drivers: stm: correct the index in master array release Chunyan Zhang <zhang.chunyan@linaro.org> - 2016-02-14 07:30 +0100
    Re: [PATCH] drivers: stm: correct the index in master array release Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-15 11:40 +0100

csiph-web