Re: [PATCH 6/9] cpufreq: governor: Reset sample delay in store_sampling_rate()

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/9] cpufreq: governor: Reset sample delay in store_sampling_rate()
Date	2016-02-15 10:00 +0100
Message-ID	<r2naF-6Yj-3@gated-at.bofh.it> (permalink)
References	<r2g9b-2nN-3@gated-at.bofh.it> <r2g9c-2nN-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 15-02-16, 02:20, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> If store_sampling_rate() updates the sample delay when the ondemand
> governor is in the middle of its high/low dance (OD_SUB_SAMPLE sample
> type is set), the governor will still do the bottom half of the
> previous sample which may take too much time.
> 
> To prevent that from happening, change store_sampling_rate() to always
> reset the sample delay to 0 which also is consistent with the new
> behavior of cpufreq_governor_limits().
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/cpufreq/cpufreq_governor.c |   16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 6/9] cpufreq: governor: Reset sample delay in store_sampling_rate() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-15 02:30 +0100
  Re: [PATCH 6/9] cpufreq: governor: Reset sample delay in  store_sampling_rate() Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-15 10:00 +0100

csiph-web