Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1334234
| From | Sagi Grimberg <sagig@dev.mellanox.co.il> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] block: check virt boundary in bio_will_gap() |
| Date | 2016-02-15 09:30 +0100 |
| Message-ID | <r2mHF-6N6-13@gated-at.bofh.it> (permalink) |
| References | <r2lse-64X-5@gated-at.bofh.it> <r2lsf-64X-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 4571ef1..b8ff6a3 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1388,7 +1388,7 @@ static inline bool bvec_gap_to_prev(struct request_queue *q,
> static inline bool bio_will_gap(struct request_queue *q, struct bio *prev,
> struct bio *next)
> {
> - if (!bio_has_data(prev))
> + if (!bio_has_data(prev) || !queue_virt_boundary(q))
> return false;
Can we not do that?
bvec_gap_to_prev is already checking the virt_boundary and I'd sorta
like to keep the motivation to optimize bio_get_last_bvec() to be O(1).
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] block: fix bio_will_gap() Ming Lei <ming.lei@canonical.com> - 2016-02-15 08:10 +0100
[PATCH 2/4] block: check virt boundary in bio_will_gap() Ming Lei <ming.lei@canonical.com> - 2016-02-15 08:10 +0100
Re: [PATCH 2/4] block: check virt boundary in bio_will_gap() Sagi Grimberg <sagig@dev.mellanox.co.il> - 2016-02-15 09:30 +0100
Re: [PATCH 2/4] block: check virt boundary in bio_will_gap() Ming Lei <ming.lei@canonical.com> - 2016-02-15 11:30 +0100
Re: [PATCH 2/4] block: check virt boundary in bio_will_gap() Sagi Grimberg <sagig@dev.mellanox.co.il> - 2016-02-15 21:30 +0100
Re: [PATCH 2/4] block: check virt boundary in bio_will_gap() Ming Lei <ming.lei@canonical.com> - 2016-02-16 14:10 +0100
Re: [PATCH 2/4] block: check virt boundary in bio_will_gap() Ming Lei <ming.lei@canonical.com> - 2016-02-16 14:10 +0100
Re: [PATCH 0/4] block: fix bio_will_gap() Sagi Grimberg <sagig@dev.mellanox.co.il> - 2016-02-15 09:40 +0100
csiph-web