Re: [PATCH 2/3] ARM: ixp4xx: avoid warning about ioport_map() macro argument processing

From	khalasa@piap.pl (Krzysztof Hałasa)
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] ARM: ixp4xx: avoid warning about ioport_map() macro argument processing
Date	2016-02-15 08:10 +0100
Message-ID	<r2lse-64X-11@gated-at.bofh.it> (permalink)
References	<qYRqH-2CN-27@gated-at.bofh.it> <qYRqH-2CN-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> writes:

> We get a harmless compiler warning when building the cs89x0 driver
> for ixp4xx:
>
> drivers/net/ethernet/cirrus/cs89x0.c: In function 'cs89x0_ioport_probe':
> drivers/net/ethernet/cirrus/cs89x0.c:1602:28: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses]
>   io_mem = ioport_map(ioport & ~3, NETCARD_IO_EXTENT);
>
> Simply adding parentheses in the macro avoids the warning
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/arm/mach-ixp4xx/include/mach/io.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] ARM: ixp4xx: avoid warning about ioport_map() macro argument processing khalasa@piap.pl (Krzysztof Hałasa) - 2016-02-15 08:10 +0100

csiph-web