Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1333752

[PATCH 0/5] x86: remove modular references from non modular code

Show all headers | View raw

My audit of i386 allmodconfig found these instances of non-modular
code needlessly using the modular equivalents of their built-in
counterparts.

In fixing that, we get rid of some dead code, make the mandate of
the remaining code more clear, and leave behind better examples
for future platform code to copy/emulate.

Several of them are trivial, in that there is no binary output
change.  A couple others have dead code removal so the binary
output will be slightly smaller.   We've done a direct mapping
of module_init --> device_initcall in each instance, so there is
no initcall reordering risks here.  Overall, in all cases, the
runtime should be completely unchanged.

Where others have deployed module_param() already, we have to
leave it, because there is no equivalent builtin_param (not yet)
and we have to remain compatible with existing bootarg users.

Paul.
---

Cc: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: Ed Wildgoose <kernel@wildgooses.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Philip Prindeville <philipp@redfish-solutions.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86@kernel.org

Paul Gortmaker (5):
  x86: make platform/intel-quark/imr.c explicitly non-modular
  x86: make platform/intel-quark/imr_selftest.c explicitly non-modular
  x86: make platform/geode/geos.c explicitly non-modular
  x86: make platform/geode/alix.c explicitly non-modular
  x86: make platform/geode/net5501.c explicitly non-modular

 arch/x86/platform/geode/alix.c               | 14 +++++------
 arch/x86/platform/geode/geos.c               |  8 +------
 arch/x86/platform/geode/net5501.c            |  8 +------
 arch/x86/platform/intel-quark/imr.c          | 35 ++--------------------------
 arch/x86/platform/intel-quark/imr_selftest.c | 15 ++----------
 5 files changed, 13 insertions(+), 67 deletions(-)

-- 
2.6.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] x86: remove modular references from non modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 00:20 +0100
  [PATCH 4/5] x86: make platform/geode/alix.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 00:20 +0100
    [tip:x86/platform] x86/platform: Make platform/geode/  alix.c explicitly non-modular tip-bot for Paul Gortmaker <tipbot@zytor.com> - 2016-02-16 13:20 +0100
  [PATCH 3/5] x86: make platform/geode/geos.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 00:20 +0100
    [tip:x86/platform] x86/platform: Make platform/geode/  geos.c explicitly non-modular tip-bot for Paul Gortmaker <tipbot@zytor.com> - 2016-02-16 13:20 +0100
  [PATCH 1/5] x86: make platform/intel-quark/imr.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 00:20 +0100
    Re: [PATCH 1/5] x86: make platform/intel-quark/imr.c explicitly  non-modular Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2016-02-15 10:30 +0100
    [tip:x86/platform] x86/platform: Make platform/intel-quark/  imr.c explicitly non-modular tip-bot for Paul Gortmaker <tipbot@zytor.com> - 2016-02-16 13:20 +0100
  [PATCH 5/5] x86: make platform/geode/net5501.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 00:20 +0100
    [tip:x86/platform] x86/platform: Make platform/geode/  net5501.c explicitly non-modular tip-bot for Paul Gortmaker <tipbot@zytor.com> - 2016-02-16 13:20 +0100

csiph-web