Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1335987

Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO

Show all headers | View raw

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: Sat, 13 Feb 2016 19:33:15 +0530

> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
> with the error:
>  drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
>  drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
> 
> GPIO is now used to reset the switch so we should have a dependency on
> GPIOLIB. While adding the dependency also add COMPILE_TEST so that we
> can build test it.
> 
> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
> Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> 
> v2: added COMPILE_TEST and gpio/consumer.h

I'm going to apply Arnd's patch because it properly removes the
unnecessary linux/gpio.h include.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] net: phy: spi_ks8995: add dependency on GPIO Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-13 15:10 +0100
  Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO David Miller <davem@davemloft.net> - 2016-02-17 02:40 +0100
    Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-19 09:30 +0100
      Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO David Miller <davem@davemloft.net> - 2016-02-19 17:20 +0100
        Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-19 17:40 +0100

csiph-web