Re: [PATCH] net: phy: spi_ks8995: include linux/gpio/consumer.h

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: phy: spi_ks8995: include linux/gpio/consumer.h
Date	2016-02-17 02:40 +0100
Message-ID	<r2ZfY-7xT-11@gated-at.bofh.it> (permalink)
References	<r1jst-5ND-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 12 Feb 2016 11:42:34 +0100

> The ks8995 phy driver just started using gpiod_* functions, which are
> declared in linux/gpio/consumer.h, not linux/gpio.h, resulting in a
> build failure in randconfig builds that do not have CONFIG_GPIOLIB
> enabled:
> 
> drivers/net/phy/spi_ks8995.c: In function 'ks8995_probe':
> drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
> 
> This changes the header inclusion so it builds in all configurations.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")

Applied, thanks Arnd.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: phy: spi_ks8995: include linux/gpio/consumer.h Arnd Bergmann <arnd@arndb.de> - 2016-02-12 11:50 +0100
  Re: [PATCH] net: phy: spi_ks8995: include linux/gpio/consumer.h David Miller <davem@davemloft.net> - 2016-02-17 02:40 +0100

csiph-web