[PATCH] bugfix of access a invalid addr

From	<chenjie6@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH] bugfix of access a invalid addr
Date	2016-02-17 03:10 +0100
Message-ID	<r2ZJ0-7Yf-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: chenjie <chenjie6@huawei.com>

when we run fs_fsbase_t, some testcase like 
write05 failed 

write05     0  TINFO  :  Enter Block 1: test with bad fd
write05     1  TPASS  :  received EBADF as expected.
write05     0  TINFO  :  Exit Block 1
write05     0  TINFO  :  Enter Block 2: test with a bad address
write05     2  TFAIL  :  write() on an invalid buffer succeeded,
			 but should have failed

Cc: <stable@vger.kernel.org>
Signed-off-by: chenjie <chenjie6@huawei.com>

---
 fs/dax.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fs/dax.c b/fs/dax.c
index fc2e314..e1b1ff6 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -214,6 +214,11 @@ static ssize_t dax_io(struct inode *inode, struct iov_iter *iter,
 			max = min(pos + size, end);
 		}
 
+		if (unlikely(iov_iter_fault_in_readable(iter, max - pos))) {
+			retval = -EFAULT;
+			break;
+		}
+
 		if (iov_iter_rw(iter) == WRITE) {
 			len = copy_from_iter_pmem(dax.addr, max - pos, iter);
 			need_wmb = true;
-- 
1.8.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] bugfix of access a invalid addr <chenjie6@huawei.com> - 2016-02-17 03:10 +0100
  Re: [PATCH] bugfix of access a invalid addr Ross Zwisler <zwisler@gmail.com> - 2016-02-18 23:40 +0100

csiph-web