Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1335956

Re: [PATCH 1/1 v2] MIPS: DTS: cavium-octeon: provide model attribute

Show all headers | View raw

On 02/15/2016 10:35 AM, Heinrich Schuchardt wrote:
> Downstream packages like Debian flash-kernel rely on
> /proc/device-tree/model
> to determine how to install an updated kernel image.
>
> Most dts files provide this property.
>
> This patch adds a model attribute Octeon CPUs.
>
> v2:
> 	Use vendor prefix defined in vendor-prefixes.txt.
> 	Separate model from vendor by comma.
> 	Avoid wildcards.
>
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>


NAK.

These device tree templates are only used on systems with archaic 
versions of u-boot.  For all modern OCTEON systems, the device tree is 
provided by the firmware and is not under the control of the authors of 
the Linux kernel.

Whatever problem you are attempting to solve, almost by definition, 
cannot be solved by modifying these files.

We are worse off changing these, and giving people false hope that you 
are fixing something, than doing nothing.

David Daney



> ---
>   arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts | 1 +
>   arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> index 9c48e05..f70cd58 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-3860";
> +	model = "cavium,Octeon 3860";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu>;
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> index 79b46fc..0b40899 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-6880";
> +	model = "cavium,Octeon 6880";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu2>;
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-02-15 06:30 +0100
  Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-15 12:20 +0100
    Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute Arnd Bergmann <arnd@arndb.de> - 2016-02-15 12:30 +0100
    Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-02-15 19:00 +0100
      Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-15 19:20 +0100
        [PATCH 1/1 v2] MIPS: DTS: cavium-octeon: provide model attribute Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-02-15 19:40 +0100
          Re: [PATCH 1/1 v2] MIPS: DTS: cavium-octeon: provide model attribute David Daney <ddaney.cavm@gmail.com> - 2016-02-17 01:30 +0100
      Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute Aaro Koskinen <aaro.koskinen@iki.fi> - 2016-02-15 19:40 +0100
        Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-02-15 20:30 +0100
          Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute Aaro Koskinen <aaro.koskinen@iki.fi> - 2016-02-15 20:50 +0100
            Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute Aaro Koskinen <aaro.koskinen@iki.fi> - 2016-02-15 21:00 +0100
            Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-02-15 21:00 +0100

csiph-web