Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1335799
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls. |
| Date | 2016-02-16 21:30 +0100 |
| Message-ID | <r2UpZ-4mk-25@gated-at.bofh.it> (permalink) |
| References | <r2RLr-2yT-5@gated-at.bofh.it> <r2RLr-2yT-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, Feb 16, 2016 at 05:33:28PM +0000, Srinivas Kandagatla wrote:
> +static const char * const msm8x16_wcd_spk_boost_ctrl_text[] = {
> + "DISABLE", "ENABLE"};
On/off switches should be presented to usersrpace as on/off switches
with "Switch" at the end of their name not as SHOUTING enums. The
indentation and brace placement are also weird here.
I'm going to stop reviewing at this point. It really feels like this
code could benefit from taking a look at some modern CODEC drivers and
following the ways they do things, there appear to be a lot of these
issues throughout the series.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-02-16 18:40 +0100
Re: [RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls. Mark Brown <broonie@kernel.org> - 2016-02-16 21:30 +0100
Re: [RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-02-17 12:00 +0100
Re: [RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls. Mark Brown <broonie@kernel.org> - 2016-02-17 12:20 +0100
csiph-web