Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1335728

Re: [PATCH 2/3] drm/vc4: Enable runtime PM.

From Eric Anholt <eric@anholt.net>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] drm/vc4: Enable runtime PM.
Date 2016-02-16 20:00 +0100
Message-ID <r2T0S-3ha-5@gated-at.bofh.it> (permalink)
References <r04cb-4m5-25@gated-at.bofh.it> <r04lS-4r7-47@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Eric Anholt <eric@anholt.net> writes:
> +#ifdef CONFIG_PM_SLEEP
> +static int vc4_v3d_runtime_suspend(struct device *dev)
> +{
> +	struct vc4_v3d *v3d = dev_get_drvdata(dev);
> +	struct vc4_dev *vc4 = v3d->vc4;
> +
> +	vc4_irq_uninstall(vc4->dev);
> +
> +	return 0;
> +}
> +
> +static int vc4_v3d_runtime_resume(struct device *dev)
> +{
> +	struct vc4_v3d *v3d = dev_get_drvdata(dev);
> +	struct vc4_dev *vc4 = v3d->vc4;
> +
> +	vc4_v3d_init_hw(vc4->dev);
> +	vc4_irq_postinstall(vc4->dev);
> +
> +	return 0;
> +}
> +#endif

kbuild test robot caught that this #ifdef should have been CONFIG_PM,
not CONFIG_PM_SLEEP.  Fixed in v2.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 2/3] drm/vc4: Enable runtime PM. Eric Anholt <eric@anholt.net> - 2016-02-16 20:00 +0100

csiph-web