Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1335589
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 04/22] kthread: Add create_kthread_worker*() |
| Date | 2016-02-16 17:10 +0100 |
| Message-ID | <r2Qmo-1Is-37@gated-at.bofh.it> (permalink) |
| References | <qURyW-64A-19@gated-at.bofh.it> <qUS1Z-6yn-43@gated-at.bofh.it> <qUUwO-8gR-5@gated-at.bofh.it> <r2Q31-1iJ-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello, On Tue, Feb 16, 2016 at 04:44:43PM +0100, Petr Mladek wrote: > I wanted to be sure. The cpu number is later passed to > cpu_to_node(cpu) in kthread_create_on_cpu(). > > I am going to replace this with a check against nr_cpu_ids in > kthread_create_on_cpu() which makes more sense. > > I might be too paranoid. But this is slow path. People > do mistakes... idk, that just ended up adding a subtly broken code which checks for an unlikely condition which would cause a crash anyway. I don't see the point. If you want to insist on it, please at least make it a WARN_ON(). It's a clear kernel bug. Thanks. -- tejun
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v4 04/22] kthread: Add create_kthread_worker*() Petr Mladek <pmladek@suse.com> - 2016-02-16 16:50 +0100 Re: [PATCH v4 04/22] kthread: Add create_kthread_worker*() Tejun Heo <tj@kernel.org> - 2016-02-16 17:10 +0100 Re: [PATCH v4 04/22] kthread: Add create_kthread_worker*() Petr Mladek <pmladek@suse.com> - 2016-02-16 17:20 +0100
csiph-web