Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1335623

Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support

From Peter Hurley <peter@hurleysoftware.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support
Date 2016-02-16 17:40 +0100
Message-ID <r2QPp-1Uv-39@gated-at.bofh.it> (permalink)
References <r2tSO-3jp-11@gated-at.bofh.it> <r2tSO-3jp-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Michal,

On 02/15/2016 08:05 AM, Michal Simek wrote:
> Support early console setup via DT for all listed compatible strings.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  drivers/tty/serial/xilinx_uartps.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 009e0dbc12d2..6f5657766815 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -1094,6 +1094,9 @@ static int __init cdns_early_console_setup(struct earlycon_device *device,
>  	return 0;
>  }
>  EARLYCON_DECLARE(cdns, cdns_early_console_setup);
> +OF_EARLYCON_DECLARE(cdns_a, "xlnx,xuartps", cdns_early_console_setup);
> +OF_EARLYCON_DECLARE(cdns_b, "cdns,uart-r1p8", cdns_early_console_setup);
> +OF_EARLYCON_DECLARE(cdns_c, "cdns,uart-r1p12", cdns_early_console_setup);

Earlycon now shares a common framework in linux-next.

The EARLYCON_DECLARE() can be deleted and the OF_EARLYCON_DECLARE()
can all share the same earlycon name. iow,

-EARLYCON_DECLARE(cdns, cdns_early_console_setup);
+OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup);
+OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup);
+OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup);

Regards,
Peter Hurley


>  /**
>   * cdns_uart_console_write - perform write operation
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/3] serial: xuartps: Enable OF earlycon support Michal Simek <michal.simek@xilinx.com> - 2016-02-15 17:10 +0100
  Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support Arnd Bergmann <arnd@arndb.de> - 2016-02-16 13:00 +0100
  Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support Peter Hurley <peter@hurleysoftware.com> - 2016-02-16 17:40 +0100
    Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support Michal Simek <michal.simek@xilinx.com> - 2016-02-18 09:20 +0100
      Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support Peter Hurley <peter@hurleysoftware.com> - 2016-02-18 18:30 +0100

csiph-web