Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1335475

Re: [PATCH v4 3/3] printk: check CON_ENABLED in have_callable_console()

From Petr Mladek <pmladek@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 3/3] printk: check CON_ENABLED in have_callable_console()
Date 2016-02-16 15:50 +0100
Message-ID <r2P6V-Gk-15@gated-at.bofh.it> (permalink)
References <r1qNk-2ew-9@gated-at.bofh.it> <r1qNl-2ew-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat 2016-02-13 03:37:12, Sergey Senozhatsky wrote:
> have_callable_console() must also test CON_ENABLED bit, not just
> CON_ANYTIME. We may have disabled CON_ANYTIME console so printk
> can wrongly assume that it's safe to call_console_drivers().
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Makes perfect sense.

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 0/2] let printk()/console_trylock() callers to cond_resched() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-12 19:40 +0100
  [PATCH v4 3/3] printk: check CON_ENABLED in have_callable_console() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-12 19:40 +0100
    Re: [PATCH v4 3/3] printk: check CON_ENABLED in  have_callable_console() Petr Mladek <pmladek@suse.com> - 2016-02-16 15:50 +0100
      Re: [PATCH v4 3/3] printk: check CON_ENABLED in  have_callable_console() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-16 16:50 +0100
  [PATCH v4 2/3] printk: set may_schedule for some of console_trylock callers Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-12 19:40 +0100
    Re: [PATCH v4 2/3] printk: set may_schedule for some of  console_trylock callers Petr Mladek <pmladek@suse.com> - 2016-02-16 15:50 +0100
      Re: [PATCH v4 2/3] printk: set may_schedule for some of  console_trylock callers Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-16 16:50 +0100

csiph-web