Re: [PATCH] rtc: s5m: De-inline large functions to save space

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtc: s5m: De-inline large functions to save space
Date	2016-02-16 15:40 +0100
Message-ID	<r2OXg-C8-17@gated-at.bofh.it> (permalink)
References	<r2Dfr-1dj-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Krzysztof,

On 02/15/2016 11:04 PM, Krzysztof Kozlowski wrote:
> Few functions were marked inline even though they were relatively large
> and sometimes used in multiple places. De-inline them to let the
> compiler decide whether optimization makes sense. This fixes inline_hunt
> report:
> drivers/rtc/rtc-s5m.c: Deinline s5m8767_rtc_set_alarm_reg, save 704 bytes
> drivers/rtc/rtc-s5m.c: Deinline s5m8767_wait_for_udr_update, save 192 bytes
>
> Reported-by: Denys Vlasenko <vda.linux@googlemail.com>
> Cc: Denys Vlasenko <vda.linux@googlemail.com>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: s5m: De-inline large functions to save space Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-16 03:10 +0100
  Re: [PATCH] rtc: s5m: De-inline large functions to save space Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-16 15:40 +0100

csiph-web