Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1335465

Re: [PATCH] perf/jvmti: add check for java alternatives cmd in Makefile

Show all headers | View raw

Hi Arnaldo and Stephane,

On Tue, Feb 16, 2016 at 12:31:26PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Tue, Feb 16, 2016 at 07:37:41AM +0100, Stephane Eranian escreveu:
> > This patch modifies the jvmti makefile to check
> > if /usr/sbin/java-update-alternatives is present.
> > If so, then use it, if not then use the altenatives
> > command. This helps handle the difference between
> > Ubuntu and Fedora Linux distributions.
> 
> Thanks, tested and applied.
> 
> We need tho to better integrate it with the 'make install' target, so
> that it gets built and installed, this way it will end up packaged by
> distros.
> 
> That, together with documentation should be enough as a first step to
> ease usage in a more widespread way.

It'd be better providing a reasonable default (if possible) or guide
to how to setup the JDIR for other distro as well.

Thanks,
Namhyung

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf/jvmti: add check for java alternatives cmd in Makefile Stephane Eranian <eranian@google.com> - 2016-02-16 07:40 +0100
  Re: [PATCH] perf/jvmti: add check for java alternatives cmd in  Makefile Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-02-16 15:40 +0100
    Re: [PATCH] perf/jvmti: add check for java alternatives cmd in  Makefile Namhyung Kim <namhyung@kernel.org> - 2016-02-16 15:40 +0100
      Re: [PATCH] perf/jvmti: add check for java alternatives cmd in  Makefile Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-02-16 17:00 +0100
  [tip:perf/core] perf jvmti:   Add check for java alternatives cmd in Makefile tip-bot for Stephane Eranian <tipbot@zytor.com> - 2016-02-17 13:10 +0100

csiph-web