Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1335333

Re: [PATCH] qxl: apply limit to relocs_num in qxl_process_single_command

Show all headers | View raw

On Tue, Feb 16, 2016 at 12:49 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> +       if (cmd->relocs_num > 65536)
> +               return -EINVAL;
>         reloc_info = kmalloc(sizeof(struct qxl_reloc_info) * cmd->relocs_num, GFP_KERNEL);
>         if (!reloc_info)
>                 return -ENOMEM;

Why not just use one of the array alloc functions like kcalloc?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] qxl: apply limit to relocs_num in qxl_process_single_command Gerd Hoffmann <kraxel@redhat.com> - 2016-02-16 12:50 +0100
  Re: [PATCH] qxl: apply limit to relocs_num in qxl_process_single_command Daniel Vetter <daniel@ffwll.ch> - 2016-02-16 13:50 +0100

csiph-web