Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read request

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read request
Date	2016-02-16 13:40 +0100
Message-ID	<r2N58-7PC-19@gated-at.bofh.it> (permalink)
References	(1 earlier) <qEnlv-7xm-13@gated-at.bofh.it> <r0miK-8tA-13@gated-at.bofh.it> <r0S8V-4pf-1@gated-at.bofh.it> <r1uxz-4IF-5@gated-at.bofh.it> <r2IRQ-5aD-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Feb 16, 2016 at 01:30:49PM +0530, Vignesh R wrote:
> On 02/13/2016 04:07 AM, Mark Brown wrote:
> > On Thu, Feb 11, 2016 at 11:03:50AM +0530, Vignesh R wrote:
> >> On 02/10/2016 01:06 AM, Mark Brown wrote:

> >>> Looking at this I can't help but think that spi_flash_read() ought to
> >>> have the stub in rather than the caller.  But given that we're pretty
> >>> much only ever expecting one user I'm not 100% sure it actually matters.

> >> Well, my initial patch set passed long list of arguments to
> >> spi_flash_read(), but Brian suggested to use struct[1] in order to avoid
> >> unnecessary churn when things need changed in the API.

> > I don't see what that has to do with my point?

> AFAIU, your previous comment was to move initialization of
> spi_flash_read_message struct to spi_flash_read(). This would mean

No, not at all.  I'm talking about how we handle the case where we don't
have hardware support for this and need to implement it in software -
currently that's in a separate place to the place where we call the
driver.

Thread

Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read  request Mark Brown <broonie@kernel.org> - 2016-02-09 20:40 +0100
  Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read  request Vignesh R <vigneshr@ti.com> - 2016-02-11 06:40 +0100
    Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read  request Mark Brown <broonie@kernel.org> - 2016-02-12 23:40 +0100
      Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read  request Vignesh R <vigneshr@ti.com> - 2016-02-16 09:10 +0100
        Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read  request Mark Brown <broonie@kernel.org> - 2016-02-16 13:40 +0100
          Re: [PATCH v5 3/5] mtd: devices: m25p80: add support for mmap read  request "R, Vignesh" <vigneshr@ti.com> - 2016-02-17 17:20 +0100

csiph-web