Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1335219

Re: [PATCHv2 02/28] rmap: introduce rmap_walk_locked()

From "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCHv2 02/28] rmap: introduce rmap_walk_locked()
Date 2016-02-16 10:40 +0100
Message-ID <r2KgW-611-7@gated-at.bofh.it> (permalink)
References <r10pQ-1zg-3@gated-at.bofh.it> <r10zy-1Ec-59@gated-at.bofh.it> <r14D8-4iJ-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Feb 11, 2016 at 10:52:08AM -0800, Andi Kleen wrote:
> "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> writes:
> 
> > rmap_walk_locked() is the same as rmap_walk(), but caller takes care
> > about relevant rmap lock.
> >
> > It's preparation to switch THP splitting from custom rmap walk in
> > freeze_page()/unfreeze_page() to generic one.
> 
> Would be better to move all locking into the callers, with an
> appropiate helper for users who don't want to deal with it.
> Conditional locking based on flags is always tricky.

Hm. That's kinda tricky for rmap_walk_ksm()..

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCHv2 00/28] huge tmpfs implementation using compound pages "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-11 15:40 +0100
  [PATCHv2 02/28] rmap: introduce rmap_walk_locked() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-11 15:40 +0100
    Re: [PATCHv2 02/28] rmap: introduce rmap_walk_locked() Andi Kleen <andi@firstfloor.org> - 2016-02-11 20:00 +0100
      Re: [PATCHv2 02/28] rmap: introduce rmap_walk_locked() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-16 10:40 +0100
  [PATCHv2 11/28] mm, rmap: account file thp pages "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-11 15:40 +0100

csiph-web