Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1335108

Re: [PATCH v7 3/8] time: Remove duplicated code in ktime_get_raw_and_real()

Show all headers | View raw

On Fri, Feb 12, 2016 at 12:25:24PM -0800, Christopher S. Hall wrote:
> The code in ktime_get_snapshot() is a superset of the code in
> ktime_get_raw_and_real() code. Further, ktime_get_raw_and_real() is
> called only by the PPS code, pps_get_ts(). Consolidate the
> pps_get_ts() code into a single function calling ktime_get_snapshot()
> and eliminate ktime_get_raw_and_real(). A side effect of this is that
> the raw and real results of pps_get_ts() correspond to exactly the
> same clock cycle. Previously these values represented separate reads
> of the system clock.

Nice improvement.

> @@ -888,6 +888,8 @@ void ktime_get_snapshot(struct system_time_snapshot *systime_snapshot)
>  	s64 nsec_real;
>  	cycle_t now;
>  
> +	WARN_ON(timekeeping_suspended);
...
> -	WARN_ON_ONCE(timekeeping_suspended);

Is this change intentional?

Thanks,
Richard

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/8] Patchset enabling hardware based cross-timestamps for next gen Intel platforms "Christopher S. Hall" <christopher.s.hall@intel.com> - 2016-02-13 04:40 +0100
  [PATCH v7 8/8] net: e1000e: Adds hardware supported cross timestamp on e1000e nic "Christopher S. Hall" <christopher.s.hall@intel.com> - 2016-02-13 04:40 +0100
    Re: [PATCH v7 8/8] net: e1000e: Adds hardware supported cross  timestamp on e1000e nic Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2016-02-19 01:50 +0100
  [PATCH v7 4/8] time: Add driver cross timestamp interface for higher precision time synchronization "Christopher S. Hall" <christopher.s.hall@intel.com> - 2016-02-13 04:40 +0100
    Re: [PATCH v7 4/8] time: Add driver cross timestamp interface for  higher precision time synchronization Richard Cochran <richardcochran@gmail.com> - 2016-02-16 09:00 +0100
  [PATCH v7 6/8] x86: tsc: Always Running Timer (ART) correlated clocksource "Christopher S. Hall" <christopher.s.hall@intel.com> - 2016-02-13 04:40 +0100
    Re: [PATCH v7 6/8] x86: tsc: Always Running Timer (ART) correlated  clocksource Andy Lutomirski <luto@kernel.org> - 2016-02-18 22:20 +0100
  [PATCH v7 2/8] time: Add timekeeping snapshot code capturing system time and counter "Christopher S. Hall" <christopher.s.hall@intel.com> - 2016-02-13 04:40 +0100
  [PATCH v7 7/8] ptp: Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping "Christopher S. Hall" <christopher.s.hall@intel.com> - 2016-02-13 04:40 +0100
  [PATCH v7 3/8] time: Remove duplicated code in ktime_get_raw_and_real() "Christopher S. Hall" <christopher.s.hall@intel.com> - 2016-02-13 04:40 +0100
    Re: [PATCH v7 3/8] time: Remove duplicated code in  ktime_get_raw_and_real() Richard Cochran <richardcochran@gmail.com> - 2016-02-16 09:00 +0100
      Re: [PATCH v7 3/8] time: Remove duplicated code in  ktime_get_raw_and_real() "Christopher Hall" <christopher.s.hall@intel.com> - 2016-02-16 19:30 +0100
  [PATCH v7 5/8] time: Add history to cross timestamp interface supporting slower devices "Christopher S. Hall" <christopher.s.hall@intel.com> - 2016-02-13 04:40 +0100
    Re: [PATCH v7 5/8] time: Add history to cross timestamp interface  supporting slower devices Richard Cochran <richardcochran@gmail.com> - 2016-02-18 23:20 +0100
      Re: [PATCH v7 5/8] time: Add history to cross timestamp interface  supporting slower devices John Stultz <john.stultz@linaro.org> - 2016-02-19 18:40 +0100
  Re: [PATCH v7 0/8] Patchset enabling hardware based cross-timestamps  for next gen Intel platforms John Stultz <john.stultz@linaro.org> - 2016-02-18 20:30 +0100
    Re: [PATCH v7 0/8] Patchset enabling hardware based cross-timestamps  for next gen Intel platforms "Christopher Hall" <christopher.s.hall@intel.com> - 2016-02-22 19:40 +0100
      Re: [PATCH v7 0/8] Patchset enabling hardware based cross-timestamps  for next gen Intel platforms John Stultz <john.stultz@linaro.org> - 2016-02-22 19:50 +0100

csiph-web