[PATCH] gpio-mcp23s08: correctly handling failed allocation

From	Insu Yun <wuninsu@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] gpio-mcp23s08: correctly handling failed allocation
Date	2016-02-16 03:30 +0100
Message-ID	<r2DyO-1ku-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Since devm_kzalloc can be failed in memory pressure,
it needs to check and return -ENOMEM

Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
 drivers/gpio/gpio-mcp23s08.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c
index c767879..ed51dcf 100644
--- a/drivers/gpio/gpio-mcp23s08.c
+++ b/drivers/gpio/gpio-mcp23s08.c
@@ -803,6 +803,8 @@ static int mcp230xx_probe(struct i2c_client *client,
 			pdata = devm_kzalloc(&client->dev,
 					sizeof(struct mcp23s08_platform_data),
 					GFP_KERNEL);
+			if (!pdata)
+				return -ENOMEM;
 			pdata->base = -1;
 		}
 	}
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio-mcp23s08: correctly handling failed allocation Insu Yun <wuninsu@gmail.com> - 2016-02-16 03:30 +0100
  Re: [PATCH] gpio-mcp23s08: correctly handling failed allocation Linus Walleij <linus.walleij@linaro.org> - 2016-02-16 16:40 +0100

csiph-web