Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334896

Re: checkpatch falsepositives in Lustre code

Show all headers | View raw

On Mon, 2016-02-15 at 18:49 -0500, Oleg Drokin wrote:
> Hello!
> 
> 
>    As I am going over Lustre to clean up the code style, I noticed this bunch below.
> 
>    Those all are function definitions, though I guess it might have been foiled by
>    return type on the previous line?
>    Now sure if anything could be done about this.
> 
>    Thanks.
> 
> ERROR: that open brace { should be on the previous line 
> #2098: FILE: drivers/staging/lustre/lustre/libcfs/hash.c:1358:
> +cfs_ash_for_each_enter(struct cfs_hash *hs)
> +{

[etc...]

Yeah, that's a defect of some type.

I'm not sure if it's really possible to handle it well though.

Maybe there could be a test added for something like

"^[\+ ](?:$Declare\s*|DeclareMisordered\s*)?\$Ident\("

to find what looks like function declarations in the
first column to avoid some of these false positives.

Andy?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: checkpatch falsepositives in Lustre code Joe Perches <joe@perches.com> - 2016-02-16 02:00 +0100
  Re: checkpatch falsepositives in Lustre code Oleg Drokin <green@linuxhacker.ru> - 2016-02-16 03:00 +0100
    Re: checkpatch falsepositives in Lustre code Joe Perches <joe@perches.com> - 2016-02-16 03:30 +0100
      Re: checkpatch falsepositives in Lustre code Oleg Drokin <green@linuxhacker.ru> - 2016-02-16 03:50 +0100
        Re: checkpatch falsepositives in Lustre code Joe Perches <joe@perches.com> - 2016-02-16 04:10 +0100
          Re: checkpatch falsepositives in Lustre code Oleg Drokin <green@linuxhacker.ru> - 2016-02-16 04:20 +0100

csiph-web