Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1333249

Re: [PATCH net-next v8 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 2016-02-09 at 16:29 -0800, David Decotigny wrote:
> From: David Decotigny <decot@googlers.com>
> 
> This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by
> the new get_ksettings/set_ksettings callbacks. This API provides
> support for most legacy ethtool_cmd fields, adds support for larger
> link mode masks (up to 4064 bits, variable length), and removes
> ethtool_cmd deprecated fields (transceiver/maxrxpkt/maxtxpkt).
[...]

I previously asked you to include 'link' in the command names and
structure name.  This would clarify that these are now only for link
settings and reduce the risk of confusion between old and new commands.
However, you didn't reply to that review.  Do you have any objection to
doing this?

Ben.

-- 
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v8 00/19] new ETHTOOL_GSETTINGS/SSETTINGS API David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:30 +0100
  [PATCH net-next v8 16/19] net: core: use __ethtool_get_ksettings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 12/19] net: fcoe: use __ethtool_get_ksettings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 01/19] lib/bitmap.c: conversion routines to/from u32 array David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
    Re: [PATCH net-next v8 01/19] lib/bitmap.c: conversion routines  to/from u32 array Ben Hutchings <ben@decadent.org.uk> - 2016-02-13 02:10 +0100
  [PATCH net-next v8 10/19] net: macvlan: use __ethtool_get_ksettings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 19/19] net: mlx4: use new ETHTOOL_G/SSETTINGS API David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 04/19] net: usnic: use __ethtool_get_settings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 11/19] net: team: use __ethtool_get_ksettings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 17/19] net: ethtool: remove unused __ethtool_get_settings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 07/19] net: usnic: use __ethtool_get_ksettings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 09/19] net: ipvlan: use __ethtool_get_ksettings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 14/19] net: 8021q: use __ethtool_get_ksettings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 03/19] net: usnic: remove unused call to ethtool_ops::get_settings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 18/19] net: mlx4: convenience predicate for debug messages David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 13/19] net: rdma: use __ethtool_get_ksettings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 08/19] net: bonding: use __ethtool_get_ksettings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 02/19] test_bitmap: unit tests for lib/bitmap.c David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
    Re: [PATCH net-next v8 02/19] test_bitmap: unit tests for  lib/bitmap.c Ben Hutchings <ben@decadent.org.uk> - 2016-02-13 02:40 +0100
  [PATCH net-next v8 06/19] tx4939: use __ethtool_get_ksettings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  [PATCH net-next v8 15/19] net: bridge: use __ethtool_get_ksettings David Decotigny <ddecotig@gmail.com> - 2016-02-10 01:40 +0100
  Re: [PATCH net-next v8 00/19] new ETHTOOL_GSETTINGS/SSETTINGS API Stephen Hemminger <stephen@networkplumber.org> - 2016-02-11 02:00 +0100
  Re: [PATCH net-next v8 05/19] net: ethtool: add new  ETHTOOL_GSETTINGS/SSETTINGS API Ben Hutchings <ben@decadent.org.uk> - 2016-02-13 02:50 +0100
    Re: [PATCH net-next v8 05/19] net: ethtool: add new  ETHTOOL_GSETTINGS/SSETTINGS API David Decotigny <ddecotig@gmail.com> - 2016-02-18 21:00 +0100

csiph-web