RE: [lustre-devel] [PATCH 06/11] staging: lustre: add missing spaces for LNet layer reported by checkpatch.pl

From	"Simmons, James A." <simmonsja@ornl.gov>
Newsgroups	linux.kernel
Subject	RE: [lustre-devel] [PATCH 06/11] staging: lustre: add missing spaces for LNet layer reported by checkpatch.pl
Date	2016-02-13 00:30 +0100
Message-ID	<r1vjX-5hf-1@gated-at.bofh.it> (permalink)
References	<r1pxU-1vA-19@gated-at.bofh.it> <r1pxW-1vA-41@gated-at.bofh.it> <r1pRi-1EI-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>On Fri, 2016-02-12 at 12:06 -0500, James Simmons wrote:
>> Add missing spaces in the code reported by checkpatch.pl.
>[]
>> diff --git a/drivers/staging/lustre/include/linux/lnet/lib-types.h b/drivers/staging/lustre/include/linux/lnet/lib-types.h
>[]
>> @@ -112,7 +112,7 @@ typedef struct lnet_libhandle {
>>  } lnet_libhandle_t;
>>  
>>  #define lh_entry(ptr, type, member) \
>> -	((type *)((char *)(ptr)-(char *)(&((type *)0)->member)))
>> +	((type *)((char *)(ptr) - (char *)(&((type *)0)->member)))
>
>This could use offsetof(type, member)

Will send a later patch to cover this.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 06/11] staging: lustre: add missing spaces for LNet layer reported by checkpatch.pl James Simmons <jsimmons@infradead.org> - 2016-02-12 18:20 +0100
  Re: [PATCH 06/11] staging: lustre: add missing spaces for LNet  layer reported by checkpatch.pl Joe Perches <joe@perches.com> - 2016-02-12 18:40 +0100
    RE: [lustre-devel] [PATCH 06/11] staging: lustre: add missing spaces  for LNet layer reported by checkpatch.pl "Simmons, James A." <simmonsja@ornl.gov> - 2016-02-13 00:30 +0100

csiph-web