Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1333055

Re: [PATCH linux-next v2 01/14] mtd: spi-nor: remove micron_quad_enable()

Show all headers | View raw

On Wed, Feb 03, 2016 at 12:16:53PM +0100, Cyrille Pitchen wrote:

> So in its current state, micron_quad_enable() prevents us from using Micron
> memories for Quad SPI operations. Some code is missing to make it work.

TL;DR: the original code adding micron_quad_enable() was broken and
should never have been merged (sorry, my bad). Next time, please test
your changes Bean.

> As I said in the patch description, using the SPI 4-4-4 protocol is not
> relevant for MTD usage. It would be worth for XIP operations but this is not the
> purpose of the spi-nor driver.

I'm not completely opposed to using it, if someone can support it well,
test it, and prove it actually provides real benefits. But none of the
above have been satisfied yet.

Regards,
Brian

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH linux-next v2 01/14] mtd: spi-nor: remove  micron_quad_enable() Brian Norris <computersforpeace@gmail.com> - 2016-02-12 20:30 +0100

csiph-web