Re: [PATCH 1/3] i2c: iproc: Add recovery mechanism in error case

From	Ray Jui <ray.jui@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] i2c: iproc: Add recovery mechanism in error case
Date	2016-02-12 20:40 +0100
Message-ID	<r1rJp-2RI-49@gated-at.bofh.it> (permalink)
References	<qVIDf-3rL-5@gated-at.bofh.it> <qVIDg-3rL-19@gated-at.bofh.it> <r1rJo-2RI-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2/12/2016 11:31 AM, Wolfram Sang wrote:
>> +static int bcm_iproc_i2c_init(struct bcm_iproc_i2c_dev *iproc_i2c);
>> +static void bcm_iproc_i2c_enable_disable(struct bcm_iproc_i2c_dev *iproc_i2c,
>> +					 bool enable);
>
> Can't we move these functions instead of having the extra declarations?
>

I had the same opinion during our internal review, :)

I'll do that in the next revision of this patch set.

Thanks,

Ray

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] i2c: iproc: Add recovery mechanism in error case Wolfram Sang <wsa@the-dreams.de> - 2016-02-12 20:40 +0100
  Re: [PATCH 1/3] i2c: iproc: Add recovery mechanism in error case Ray Jui <ray.jui@broadcom.com> - 2016-02-12 20:40 +0100

csiph-web