Re: [PATCHv3 1/3] rdmacg: Added rdma cgroup controller.

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCHv3 1/3] rdmacg: Added rdma cgroup controller.
Date	2016-02-12 17:50 +0100
Message-ID	<r1p4R-14o-13@gated-at.bofh.it> (permalink)
References	(5 earlier) <qX4s2-6Kt-3@gated-at.bofh.it> <qXrHY-6ZT-19@gated-at.bofh.it> <qXrRE-73c-25@gated-at.bofh.it> <r16OB-5Vk-7@gated-at.bofh.it> <r16Yi-5Zm-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello, Parav.

On Fri, Feb 12, 2016 at 02:49:38AM +0530, Parav Pandit wrote:
> 1. Removed two type of resource pool, made is single type (as you
> described in past comment)
> 2. Removed match tokens and have array definition like "qp", "mr", "cq" etc.
> 3. Wrote small parser and avoided match_token API as that won't work
> due to different array definition
> 4. Removed one-off remove API to unconfigure cgroup, instead all
> resource should be set to max.
> 5. Removed resource pool type (user/default), instead having max_num_cnt,
> when ref_cnt drops to zero and max_num_cnt = total_rescource_cnt, pool is freed.
> 6. Resource definition ownership is now only with IB stack at single
> header file, no longer in each low level driver.
> This goes through IB maintainer and other reviewers eyes.
> This continue to give flexibility to not force kernel upgrade for few
> enums additions for new resource type.
> 7. Wherever possible pool lock is pushed out, except for hierarchical
> charging/unchanging points, as it not possible to do so, due to
> iterative process involves blocking allocations of rpool. Coming up
> more levels up to release locks doesn't make any sense either.
> This is anyway slow path where rpool is not allocated. Except for
> typical first resource allocation, this is less traveled path.
> 8.Other minor cleanups.
> 9. Avoided %d manipulation due to removal of match_token and replaced
> with seq_putc etc friend functions.

Sounds great.  Can't tell too much without looking at the code tho.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCHv3 1/3] rdmacg: Added rdma cgroup controller. Parav Pandit <pandit.parav@gmail.com> - 2016-02-11 22:30 +0100
  Re: [PATCHv3 1/3] rdmacg: Added rdma cgroup controller. Tejun Heo <tj@kernel.org> - 2016-02-12 17:50 +0100

csiph-web