Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1332791
| From | Andrzej Hajda <a.hajda@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] err.h: allow IS_ERR_VALUE to handle properly more types |
| Date | 2016-02-12 15:50 +0100 |
| Message-ID | <r1ncK-8iz-13@gated-at.bofh.it> (permalink) |
| References | <qXTEg-2Um-47@gated-at.bofh.it> <r0Kbo-7zi-11@gated-at.bofh.it> <r0Ty2-5rv-1@gated-at.bofh.it> <r12Bk-2Ym-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02/11/2016 05:39 PM, Arnd Bergmann wrote: > On Thursday 11 February 2016 08:00:54 Andrzej Hajda wrote: >>> I think the easiest way to express this would be to ensure that the argument >>> is 'unsigned long', like: >>> >>> #define IS_ERR_VALUE(x) ((unsigned long*)NULL == (typeof (x)*)NULL && \ >>> unlikely((unsigned long long)(x) >= (unsigned long long)(typeof(x))-MAX_ERRNO)) >> This way you will limit it only to unsigned long type, which seems too >> strict to me. >> I think the macro should accept all long enough unsigned types, otherwise we >> could end up with bunch of macros IS_ERR_VALUE_U32, IS_ERR_VALUE_ULL... > I think in practice we only care about 'int' and 'unsigned long', which are > the ones that 90% of the existing users pass in today. u32 has never worked > on 64-bit architectures so far, so we don't necessarily have to make it work. > As Al mentioned, most users of IS_ERR_VALUE are wrong anyway and should > just use 'if (err < 0)' or 'if (err)'. > > We could also consider making just 'int' and 'unsigned long' allowed types > for the moment, and then change all users passing 'int' before forbidding them. > > Arnd > > OK so in short we need to fix 140 usages of the macro? Who should do them? I can create cocci patch for more obvious cases. What about these less obvious? As I understand we do not touch the macro till fixes are merged? Regards Andrzej
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3] err.h: allow IS_ERR_VALUE to handle properly more types Andrzej Hajda <a.hajda@samsung.com> - 2016-02-11 08:10 +0100
Re: [PATCH v3] err.h: allow IS_ERR_VALUE to handle properly more types Arnd Bergmann <arnd@arndb.de> - 2016-02-11 17:50 +0100
Re: [PATCH v3] err.h: allow IS_ERR_VALUE to handle properly more types Andrzej Hajda <a.hajda@samsung.com> - 2016-02-12 15:50 +0100
Re: [PATCH v3] err.h: allow IS_ERR_VALUE to handle properly more types Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-11 22:20 +0100
csiph-web