Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332560

Re: [PATCH v2] of: resolver: Add missing of_node_get and of_node_put

Show all headers | View raw

Hi Rob,

> On Feb 12, 2016, at 01:18 , Rob Herring <robh+dt@kernel.org> wrote:
> 
> On Wed, Feb 3, 2016 at 12:09 PM, Amitoj Kaur Chawla
> <amitoj1606@gmail.com> wrote:
>> In __of_find_node_by_full_name, add an of_node_get when detecting the
>> desired element, to ensure that it ends up with a reference count that is
>> one greater than on entering the function.
>> 
>> Also in __of_find_node_by_full_name, add an of_node_put on breaking
>> out of the for_each_child_of_node loop, to ensure that the reference
>> count of the returned value is not double incremented. This change
>> was made using Coccinelle.
> 
> Pantelis, are you convinced this is correct (albeit somewhat pointless)?
> 

This is good enough. It’s a local method and we won’t ever try to use
it outside of the resolver. We need to fix the reference counting properly
sometime in the future.

> Rob

Regards

— Pantelis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] of: resolver: Add missing of_node_get and of_node_put Rob Herring <robh+dt@kernel.org> - 2016-02-12 00:20 +0100
  Re: [PATCH v2] of: resolver: Add missing of_node_get and of_node_put Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-02-12 09:00 +0100

csiph-web