[patch] regulator: qcom-saw: testing the wrong variable

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] regulator: qcom-saw: testing the wrong variable
Date	2016-02-12 07:50 +0100
Message-ID	<r1fId-3jp-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

We accidentally test "config.regmap" which is zero instead of
"vreg->regmap".

Fixes: 18bba3b50355 ('regulator: qcom-saw: Add support for SAW regulators')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/regulator/qcom_saw-regulator.c b/drivers/regulator/qcom_saw-regulator.c
index c800f16..c00f0df 100644
--- a/drivers/regulator/qcom_saw-regulator.c
+++ b/drivers/regulator/qcom_saw-regulator.c
@@ -186,8 +186,8 @@ static int qcom_saw_regulator_probe(struct platform_device *pdev)
 
 	vreg->regmap = syscon_node_to_regmap(saw_np);
 	of_node_put(saw_np);
-	if (IS_ERR(config.regmap))
-		return PTR_ERR(config.regmap);
+	if (IS_ERR(vreg->regmap))
+		return PTR_ERR(vreg->regmap);
 
 	snprintf(name, sizeof(name), "krait%d", cpu);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[patch] regulator: qcom-saw: testing the wrong variable Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-12 07:50 +0100

csiph-web