Re: [PATCH] staging: lustre/lnet: Fix wrong type casting warning generated by sparse

From	Niranjan Dighe <niranjan.dighe@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: lustre/lnet: Fix wrong type casting warning generated by sparse
Date	2016-02-14 03:50 +0100
Message-ID	<r1UV3-55l-1@gated-at.bofh.it> (permalink)
References	<r1MNQ-8o9-9@gated-at.bofh.it> <r1QeK-1UL-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Feb 14, 2016 at 3:19 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Sat, Feb 13, 2016 at 11:34:35PM +0530, Niranjan Dighe wrote:
>> diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
>> index 366211e..64b6a70 100644
>> --- a/drivers/staging/lustre/lnet/selftest/console.c
>> +++ b/drivers/staging/lustre/lnet/selftest/console.c
>> @@ -1461,9 +1461,9 @@ lstcon_statrpc_readent(int transop, srpc_msg_t *msg,
>>
>>       sfwk_stat = (sfw_counters_t __user *)&ent_up->rpe_payload[0];
>>       srpc_stat = (srpc_counters_t __user *)
>> -                                   ((char *)sfwk_stat + sizeof(*sfwk_stat));
>> +                             ((char __user *)sfwk_stat + sizeof(*sfwk_stat));
>
> This is uglier than necessary.  Do it either like this:
>
>         srpc_stat = (void __user *)sfwk_stat + sizeof(*sfwk_stat);
>
> Or probably it's actually nicer to say:
>
>         srpc_stat = sfwk_stat + 1;
>
> regards,
> dan carpenter
>

Yes, thanks Dan, I will send out a new patch. Please discard this one.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre/lnet: Fix wrong type casting warning  generated by sparse Niranjan Dighe <niranjan.dighe@gmail.com> - 2016-02-13 19:10 +0100
  Re: [PATCH] staging: lustre/lnet: Fix wrong type casting warning  generated by sparse Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-13 22:50 +0100
    Re: [PATCH] staging: lustre/lnet: Fix wrong type casting warning  generated by sparse Niranjan Dighe <niranjan.dighe@gmail.com> - 2016-02-14 03:50 +0100

csiph-web