Re: [PATCH RFC 1/3] net: bridge: log state when setting it

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC 1/3] net: bridge: log state when setting it
Date	2016-02-13 22:50 +0100
Message-ID	<r1QeK-1UL-3@gated-at.bofh.it> (permalink)
References	<r1tBw-44h-7@gated-at.bofh.it> <r1tBw-44h-9@gated-at.bofh.it> <r1OFY-16I-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Ido,

Ido Schimmel <idosch@mellanox.com> writes:

> Fri, Feb 12, 2016 at 11:34:18PM IST, vivien.didelot@savoirfairelinux.com wrote:
>
> Hi Vivien,
>
>>Every call to br_set_state is followed by a call to br_log_state.
>>Directly call it within br_set_state instead.
>>
>>Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>>---
>
> Maybe I'm missing something, but there are other instances of this
> pattern throughout the code, so why not convert them as well? See
> br_set_port_state() for example.

Good catch, I'll factorize that and send this as a unique patch then.

Thanks,
-v

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RFC 1/3] net: bridge: log state when setting it Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-02-12 22:40 +0100
  Re: [PATCH RFC 1/3] net: bridge: log state when setting it Ido Schimmel <idosch@mellanox.com> - 2016-02-13 21:10 +0100
    Re: [PATCH RFC 1/3] net: bridge: log state when setting it Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-02-13 22:50 +0100

csiph-web